Consider AngleSharp to replace CsQuery about htmlsanitizer

[mganss]

I started a port to AngleSharp (AngleSharp branch). A large number of tests are not passing yet, though. This is mostly due to AngleSharp/AngleSharp#101.

[304NotModified]

👍

[304NotModified]

I see some discussion at the Github issue of AngleSharp. Do you think they will solve the things that are needed for the replacement?

[mganss]

I've just pushed an update to the AngleSharp branch with only around 10 tests still failing. I think most if not all of these only have to be changed so that the expected output matches the actual output.

[thefringeninja]

I see that there is a nuget package for this https://www.nuget.org/packages/HtmlSanitizer/3.1.67-beta and that all tests of the AngleSharp branch pass on my machine. Can this be merged back into master yet?

[mganss]

I'm planning to do this in a couple of days if no issues pop up during that time. Does the beta work for your use case?

[thefringeninja]

Yes it does, and I don't mind depending on a pre release package for the
time being. Take your time :) I'll report any issues here if I get them.

On Thu, Nov 26, 2015 at 3:22 PM, Michael Ganss [email protected]
wrote:

I'm planning to do this in a couple of days if no issues pop up during
that time. Does the beta work for your use case?

—
Reply to this email directly or view it on GitHub
#34 (comment)
.

Sent from my regular computer
http://twitter.com/thefringeninja
http://www.thefringeninja.com/

[rmichela]

Any plans on merging the anglesharp branch to master?

[mganss]

Yes, any day now. I want to include #51 and then merge to master.

[StanislavPrusac]

(y) for AngleSharp

[mganss]

3.1.76 uses AngleSharp instead of CsQuery.

[tiesont]

@mganss I realize the train has left the station already on this, but given that AngleSharp seems to be the root cause of a disproportionate number of new issues, are you really gaining anything over using CsQuery? I personally found CsQuery easier to use; does AngleSharp provide functionality not present in CsQuery, or is it just that AngleSharp is actively maintained?

[mganss]

It's mostly because AngleSharp is actively maintained. Just yesterday I opened two PRs and got a response within minutes. In contrast, look what happened with #36.

I also found CsQuery easier to use. I don't think that for our use case there is functionality in AngleSharp that's missing from CsQuery. But there's one aspect I have come to appreciate in AngleSharp: It does exactly the same as a browser, even the API is mostly identical, i.e. you can take any HTML snippet and try it in the browser console.

[tiesont]

Fair enough. Hopefully, once AngleSharp gets to the 1.0 milestone, they'll realize they can't keep introducing breaking changes. Thanks for the response.

[304NotModified]

. Hopefully, once AngleSharp gets to the 1.0 milestone, they'll realize they can't keep introducing breaking changes.

Couldn't agree more!

PS: CSQuery is also not ported to netstandard, and that is of course important for the (near) future.

[304NotModified]

Looks like 1.0 is near for AngleSharp: