Coder Social home page Coder Social logo

Comments (4)

mfherbst avatar mfherbst commented on August 15, 2024 1

I see, but if I do the following, after running your code:

position(load_system(AseParser(), "TaSe2-chemfile.cif")) .- position(load_system(ChemfilesParser(), "TaSe2-chemfile.cif"))
bounding_box(load_system(AseParser(), "TaSe2-chemfile.cif")) .- bounding_box(load_system(ChemfilesParser(), "TaSe2-chemfile.cif"))

position(load_system(AseParser(), "TaSe2-ase.cif")) .- position(load_system(ChemfilesParser(), "TaSe2-ase.cif"))
bounding_box(load_system(AseParser(), "TaSe2-ase.cif")) .- bounding_box(load_system(ChemfilesParser(), "TaSe2-ase.cif"))

The differences are tiny, suggesting to me that they both represent the same structures. Also viewing both cif files in ASE's builtin viewer they look exactly the same to me. Maybe this is actually a bug in the viewer you are using?

from atomsio.jl.

mfherbst avatar mfherbst commented on August 15, 2024

Thanks for reporting. At the moment I'm also not sure whether this is an issue and where it arises. Since the Chemfiles interface is very little code, my suspicion would be to look in Chemfiles.jl.

Could you go a little more into details what you tried to ensure the two structures are different ? E.g. could they not be just a different representation of the unit cell ? On that note can you post / compare some geometry details, such as interatomic distances or similar? Also with the QE input if possible ?

Thanks!

from atomsio.jl.

jywu20 avatar jywu20 commented on August 15, 2024

Thanks for your reply. I double checked and it seems the two structures are indeed different: it's possible to find a viewpoint from which the atoms in TaSe2-chemfile.cif look as if they are on the same line:

3

while this is wrong for a 1T-TMD (transition metal dichalcogenide) and is never possible for TaSe2-ase.cif.

Below is a further piece of evidence: this is the expected structure from TaSe2-ase.cif:

1

And this is the wrong structure in TaSe2-chemfile.cif, from the same perspective: you can see that the two Se atoms (green balls) are all below the Ta atoms, which is wrong.
2

The lattice constants of the two structures as well as the angles between the edges are the same in the two structures.

The QE input file is already in my first post.

from atomsio.jl.

jywu20 avatar jywu20 commented on August 15, 2024

I tried your test and on my machine it also seems that the two files represent the same structures. I haven't checked whether VESTA (the viewer I'm using) works as expected here ... this then seems to be a problem of incorrect CIF parsing in VESTA. Thanks for looking into the issue!

from atomsio.jl.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.