Coder Social home page Coder Social logo

Comments (3)

mezz64 avatar mezz64 commented on June 24, 2024

Thanks for digging into this. I only recently realized (thanks to a recent PR) that the timeout being set on the requests session object is doing nothing. With that knowledge the reconnect issues certainly make a lot more sense.

I see in your fork you added the timeout parameter to the init function, do you have a use case for this? I'd rather just set constants for connection and read timeout (5 and 60) and pass them into the appropriate functions as needed. I think these values are fairly safe and it's unlikely they would need tweaked higher.

from pyhik.

shaibt avatar shaibt commented on June 24, 2024

In my use case I have different sensitivities to camera reconnect times so I initially added to init() so will be configurable but on second thought its not that important and setting constants is good enough

from pyhik.

mezz64 avatar mezz64 commented on June 24, 2024

Suggestions have been implemented. I'm leaving the watchdog for now, but may remove it later. As you've mentioned with the timeouts properly in place it really shouldn't be needed.

from pyhik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.