Expand docs for MA0099 about meziantou.analyzer

[meziantou]

Default values should be handled correctly. It looks like a bug, I'll have a look at it soon.

[meziantou]

I can repro on Roslyn 4.4 and before, but it's fine on 4.5 (latest).
I will investigate later. As a workaround, you can update VS or the .NET SDK.

[meziantou]

I cloned your project, but I do not get any MA0099. Just to be sure I added dotnet_diagnostic.MA0099.severity = error and run dotnet build.

Could you try to create a simple repro?

[erri120]

https://sharplab.io/#v2:C4LghgzsA0AmIGoA+ABATARgLAChcDswBbAUwgAcwBjEgAgFkSAvASzH2AHsBXAOgEFCAGwCeTEgCde9fgAZZATgUBuXLhQBmWiXzciDEQFFdRXAG9ctK7QBynfHQC8tWdEvWAyp1K1nGNzgAvmo4ANr8wMASLABG3MAkAKoQYADmJAAUEVGx8SQAKmAS6cAQAkJCAJQAuupa6AbZ0XEJtCC0TbkJ5u5Wmo2RzXkZ9EYmtDFFvgbGerx2DpW0ZrTBQSGho50tJNW0APT7tADuRfgs+Knt3BB0hgAe5EIsVCzA2uMAbmBC3HQAZpwJLQAOSjWZEEG0C5QEhgWC0Tj/Fx1WgNUYAYSEkAgPRw1jRWkx2IgEBGYz0tEBnGm4JM83sJCWKzWvUJaIwADYDFicbQMRI4QkMpU2RZ8QTrCgAOy0BzHHkksmVZQHI74GmnCTnS5staBIA==

public enum MyEnum
{
    None = 0,
    Some = 1,
}

[AttributeUsage(AttributeTargets.All)]
public class MyAttribute : Attribute
{
    public MyAttribute(MyEnum bar = MyEnum.None) { }
}

[MyAttribute] // warning: use Explicit enum value for 'MyEnum' instead of 0
public class MyClass
{
    public MyClass(MyEnum foo = MyEnum.None) { }

    public static MyClass Create()
    {
        return new MyClass(); // no warning
    }
}

I've tried various combinations, but only default values in attributes seem to trigger this warning.

[meziantou]

Which version of Roslyn and which language version do you use?
You can use #error version to get the information. See Getting Roslyn (C# compiler) and Language versions for more info.

[erri120]

Which version of Roslyn and which language version do you use? You can use #error version to get the information. See Getting Roslyn (C# compiler) and Language versions for more info.

Compiler version: '4.4.0-6.23068.5 (0760f14e)'. Language version: 11.0.

dotnet --info output:

.NET SDK:
 Version:   7.0.103
 Commit:    276c71d299

Runtime Environment:
 OS Name:     arch
 OS Version:
 OS Platform: Linux
 RID:         arch-x64
 Base Path:   /usr/share/dotnet/sdk/7.0.103/

Host:
  Version:      7.0.3
  Architecture: x64
  Commit:       0a2bda10e8

.NET SDKs installed:
  6.0.114 [/usr/share/dotnet/sdk]
  7.0.103 [/usr/share/dotnet/sdk]