MA0075: false positive for implicit `ToString()` on char about meziantou.analyzer

[meziantou]

I can reproduce the error using the following test:

    [Fact]
    [Trait("Issue", "https://github.com/meziantou/Meziantou.Analyzer/issues/516")]
    public async Task ConcatNoDiagnostic_Char()
    {
        var sourceCode = """
class Test
{
    void A()
    {
        var c = '!';
        _ = "abc" + char.ToLower(c, System.Globalization.CultureInfo.InvariantCulture);
    }
}
""";
        await CreateProjectBuilder()
              .WithSourceCode(sourceCode)
              .ValidateAsync();
    }

I think the fix should be at

Meziantou.Analyzer/src/Meziantou.Analyzer/Internals/CultureSensitiveFormattingContext.cs

Line 103 in 83f0d0e

return true;

. It should check the return type instead of return true (return IsCultureSensitiveType(invocation.Type, options);)

[drieseng]

@meziantou, I hereby grant you permission to commit the fix :-)

[drieseng]

Please hold off on fixing this until I've fixed #464 and #488. That should motivate me :)

[drieseng]

@meziantou, thanks again!