[MA0134] False positive when using null conditional operator about meziantou.analyzer

[meziantou]

If foo is not null, the task is executed, but the result is not used. So, I'm not sure this is a false-positive.

Should your code be:

if (foo != null)
{
   await foo.BarAsync();
}

[Pretasoc]

Thats not the reason, why i'm thinking, its a false positive. In your example you said _ = Task.Delay(1); is ok. I am aware, that a task maybe is executed, but i don't care for the result, if it is. At least, thats what i'm trying to express with discard.

Of course i could write:

if (foo != null)
{
   _ = foo.BarAsync();
}

which would also not raise a warning. But i find this rather complex, compared to the single line avobe.

[meziantou]

I see... I think you are right!

The expected behavior is:

// report diagnostic
instance.ReturnTask();
instance?.ReturnTask();

// ok
_ = instance.ReturnTask();
_ = instance?.ReturnTask();