Coder Social home page Coder Social logo

Comments (3)

laimisf avatar laimisf commented on June 8, 2024

Also, when validation is executed, all 'captchaHash' session array is forgotten, instead of forgetting only one single array element on which check was executed.
Why not to do Session::forget('captchaHash.' . $formId) in check() function instead of forgetting all array elements, like now (Session::forget('captchaHash')?

One more thing, check() function could have $forgetSession parameter by default set to 'true', like check($value, $formId = null, $forgetSession = true). In this way, people could use this function for captcha check via AJAX and not forget the session that inner script validation could pass.

Edited function proposal:

public function check($value, $formId = null, $forgetSession = true)
    {
        if (!$formId) {
            $formId = hash('sha256', URL::previous());
        }
        $captchaHash = Session::get('captchaHash.' . $formId);
        $result = $value != null
            && $captchaHash != null
            && strlen($value) === $this->config['length'] // must be of the same length right?
            && $this->hashCheck($value, $captchaHash);
        // forget the hash to prevent replay
        if($forgetSession) Session::forget('captchaHash.' . $formId);
        return $result;
    }

from captcha.

toplan avatar toplan commented on June 8, 2024

uhh...I think if couldn't pass via AJAX, should create a new captcha code and return the img data back to browser!

from captcha.

toplan avatar toplan commented on June 8, 2024
if( ! $result || ! \Request::ajax() ){
            // forget the hash to prevent replay
            Session::forget('captchaHash');
 }

from captcha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.