Comments (2)
(original post before rewriting as user story)
Summary
The based_on
field previously only stored the "model id" a.k.a. the name of the model file without extension. However, this causes collisions when there are nested model directories that have the same file name in them.
Current behavior
The based_on
field will store file paths relative to the yaml the field is stored in (still without extensions). This should propogate through to the run_log()
output in such a way that the user can trace model ancestry unambiguously.
Possible extension
The run_log tibble (which can be joined easily with log_df <- run_log() %>% add_config()
) also contains the model ancestry in the based_on
field. This allows establishment of a tree of model ancestry (parents and children of a given model). If a model_ancestry()
function is implemented then we could also filter to any children of models that are out-of-date, because those should likely also be re-run.
Decide whether this should be part of this enhancement or should constitute their own separate issue. I think this should be implemented here as well.
from bbr.
I will likely do #77 in tandem with this because if not we will have to circle back and modify this code to look for both yml and yaml files.
from bbr.
Related Issues (20)
- param_estimates_batch breaks with newest data.table release HOT 2
- Function to run NMTRAN on a model object HOT 7
- Feature request: make `get_data_path` also read in the path from the ctl HOT 3
- test-initial-estimates.R: missing skips for old nmrec
- Point to bbr.bayes in readme HOT 1
- config_log error when model run with multiple NONMEM versions HOT 5
- param_estimates and initial_estimates use different names for THETA records HOT 2
- `model_summary` bug when called via `summary_log()` HOT 2
- Bootstrap: revisit how we sample the input data HOT 2
- dOFV and AIC columns for summary_log() HOT 1
- Bootstrap: mechanism to only include data that entered the original problem
- Bootstrap: function adjustments needed HOT 3
- Address deprecated warning in function `check_grd`
- Bootstrap runs should inherit attached bbi_args HOT 1
- inherit_param_estimates: revisit rounding and use matrix-handling PR HOT 1
- check_nonmem_finished and get_model_status refactor: improve wait times & change functionality HOT 8
- WK files created by bbr - delete by default? HOT 7
- Consider fail-safe for checking on terminated models HOT 4
- bbi package installation failed HOT 7
- Option to start bootstrap runs at final estimates from parent run HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bbr.