model_summary() Intermediate Printout about bbr

[callistosp]

Update: this appears to be related to a change in the last PR into develop. Even when importing the results from the completed model, it still thinks the model did not run and looks for OUTPUT.

> restest <- rbabylon::import_result(file.path(MODEL_DIR, "101.yaml")) 
> restest %>% model_summary(.wait=0) 
/data/rbabylon-example-project/model/pk/101/101.ext file does not look finished but there is also no `101/OUTPUT` file. Your run may have failed. 
--- 
Model is still running. Tail of `101/OUTPUT` file:  
---
FALSEError in nonmem_summary(.res, ...) :    101.ctl is not finished and 0 second wait time has elapsed. Check back later or increase `.wait`.
--

 
  |  
 

[dpastoor]

seth and i discussed that this morning some, I think this model_summary needs an overhaul.

Here is what I am thinking - model_summary() should only work if the model is completed.

1. we need to define how we can reliably detect completion, as quickly as possible. For example scanning the entire ext file for -1000000 lines means reading that entire file, which could be quite large.

2. It should just return either a model result, or print a message saying model not completed, no summary avialable, and return NULL

3. we need to separately provide monitoring functions that can handle whatever waiting the scientist may want

spec %>% submit_model() %>% wait_until_complete() %>% summarize_model()

the reason that waiting should be moved outside of specific submission is this allows composability and other customization. For example, maybe we want to provide a wait function that also has enough logic to know about failures - basically a specific tryCatch

spec %>% submit_model() %>% 
    wait_until_complete(error = function(e) {
       # some details of what to do if error occurs
    }) %>% 
    summarize_model()

[callistosp]

that seems like a reasonable expectation to me. if you're pulling out wait_until_complete, it would also be nice to have a wait_until_starts. e.g. if I'm shooting off some runs overnight before I leave work, I would run spec %>% submit_model %>% wait_until_starts() to verify that the run started before I shutdown my workflow

[seth127]

@callistosp this will be closed when the linked PR merges. The fix is that model_summary() just stops with an informative error if it can't get a summary (see tests mentioned below). We are intending to make a better version of check_nonmem_progress() in a future release, and this will be incorporated into model_summary() under the hood.

If you have thoughts on how you would like that to work, like some of the ones you put in the comments above, you can open a new issue with the desired functionality and tag it with the milestone roadmap.

Tests

• tests/testthat/test-summary.R
  • model_summary() fails predictably if it can't find some parts (i.e. model isn't finished)
  • model_summary() fails predictably if no .lst file present

[seth127]

We're closing this because there is another issue to deal with this:
#31