middleware not taking effect? about compojure-api

[Deraen]

I guess your wrap-dashed-params middleware is only editing request :params. You should edit :query-params and :body-params because those are the parts of request that Compojure-api reads.

[arnab]

Ah, that makes sense. AFK. I'll try it out later.

Thanks for the quick reply.

• Arnab
  http://arnab-deka.com
  On Aug 11, 2014 7:12 PM, "Juho Teperi" [email protected] wrote:

I guess your wrap-dashed-params middleware is only editing request
:params. You should edit :query-params and :body-params because those are
the parts of request that Compojure-api reads.

—
Reply to this email directly or view it on GitHub
#40 (comment)
.

[arnab]

Hi @Deraen, I changed my middleware and got the transliteration done. However, compojure-api (rather swagger and prismatic-schema) fails the incoming HTTP request as invalid. That's because

• the schema specifies per_page as the param.
  • That's what I want the swagger doc and api to look like, so it's natural from JS or Rails to call from.
• The incoming HTTP request indeed sends per_page and that's fine.
• But the middleware now changes it to per-page and that does not match the schema anymore.
  • I want my app's clojure code to work with idiomatic dasherized names.

Is there a way around this (short of calling something like this on every route):

(ok (underscorize (api/index (dasherize params))))

I could write a HOF to make the duplication less, but that's still not an ideal solution, IMO. I basically want something that allows the schema/api to have _s and the internal of my app to deal with - instead of _s.

[ikitommi]

I would resolve this with overriding compojure-api restucturing dispatch functions :query and :query-params. Like this:

(original here):

(require '[compojure.api.meta :as meta])

(declare dasherize) ;; implement
(declare un-dasherize) ;; implement

(defmethod meta/restructure-param :query-params [_ query-params acc]
  (let [schema (meta/fnk-schema query-params)
        pimped (un-dasherize schema)]
       (-> acc
           (update-in [:parameters :parameters] conj {:type :query :model pimped})
           (update-in [:letks] into [query-params `(dasherize ~(meta/src-coerce! pimped :query-params :query))]))))

with this, you can say:

(GET* "/" []
  :return Long
  :query-params [per-page :- Long]
  (ok per-page))

... while the input models (& swagger-docs) have the per_page.

more info at doing your own restructuring at: https://github.com/metosin/compojure-api#creating-your-own-metadata-handlers

hope this helps.

[ikitommi]

works for me, will close this. please reopen if still need help with this one.

cheers.

[arnab]

Thanks, I forgot to reply here. We ended up writing an HOF to do the camel-case on the way in and underscore on the way out.

[ikitommi]

ok, great to hear you got it working. But what is HOF?

[ikitommi]

a higher order function, found it :)

[arnab]

Heh. sorry :) I thought that was lingua franca in Clojure :)