Comments (5)
Hi @cvolant sure, please open your PR and let's do it.
from todos.
I now have a working branch that updates everything, transforms all class components into functional components, creates a simple hook-handled global state, fixes some issues (menu, not-found), improve PropTypes, BUT... breaks tests. :(
I searched for a solution a whole day without success: I am tired of it, and I have others things to do. Testing in Meteor already wasn't very documented long ago, and there isn't any other new documentation since then, so now it is both scarce and outdated... It would be great to be able to use react-testing-library...
Do you think I should submit the PR and then we try to fix the problem, or we first need to fix the problem?
If anyone wants to try, here it is:
https://github.com/cvolant/todos/tree/react-update-all+move-to-functional-components-with-hooks
from todos.
@cvolant please submit the PR then we can work together in the testing part. Sound good?
from todos.
@filipenevola OK then here it is: #277
If you can have a look at the tests, that would be great. I tried mounting, shallowing, rendering the ListHeader, but no luck, I keep running into errors no matter what I try with each of them...
from todos.
I improved the PR thanks to HorusGoul review. The tests are still broken, but it is better.
The server tests all pass, but 3 of the client tests fail, I don't know why...
from todos.
Related Issues (20)
- Apollo branch needs to be updated to reflect current Apollo project. HOT 5
- Any interest in a Vue port? HOT 17
- Cannot serve the built app through an ad-hoc local network
- Update React Todo to use TypeScript since PropTypes deprecation HOT 1
- replace createContainer with withTracker HOT 1
- CSS Import?
- http://todos.mysite.com redirect to https://todos.mysite.com HOT 1
- Current version won't start (last commit 59f6621 on 27 Apr 2017) HOT 1
- Add Server Side Rendering and Dynamic Imports to React To Dos HOT 1
- Why are collections not imported or defined in the register-api / api.js file ? Where are they imported and defined? HOT 3
- Where are collections defined and imported? HOT 1
- Why the code looks so messy? HOT 2
- ant-design branch ready to pull HOT 2
- Uncaught Error: Target container is not a DOM element. HOT 6
- Error Connection Websocket
- Cannot find sockjs HOT 1
- todos example doesn't run, error in meteor npm i
- german language HOT 1
- Official Example doesn't update to latest version 1.11.x HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from todos.