Coder Social home page Coder Social logo

Comments (5)

filipenevola avatar filipenevola commented on June 26, 2024

Hi @cvolant sure, please open your PR and let's do it.

from todos.

cvolant avatar cvolant commented on June 26, 2024

I now have a working branch that updates everything, transforms all class components into functional components, creates a simple hook-handled global state, fixes some issues (menu, not-found), improve PropTypes, BUT... breaks tests. :(

I searched for a solution a whole day without success: I am tired of it, and I have others things to do. Testing in Meteor already wasn't very documented long ago, and there isn't any other new documentation since then, so now it is both scarce and outdated... It would be great to be able to use react-testing-library...

Do you think I should submit the PR and then we try to fix the problem, or we first need to fix the problem?
If anyone wants to try, here it is:
https://github.com/cvolant/todos/tree/react-update-all+move-to-functional-components-with-hooks

from todos.

filipenevola avatar filipenevola commented on June 26, 2024

@cvolant please submit the PR then we can work together in the testing part. Sound good?

from todos.

cvolant avatar cvolant commented on June 26, 2024

@filipenevola OK then here it is: #277
If you can have a look at the tests, that would be great. I tried mounting, shallowing, rendering the ListHeader, but no luck, I keep running into errors no matter what I try with each of them...

from todos.

cvolant avatar cvolant commented on June 26, 2024

I improved the PR thanks to HorusGoul review. The tests are still broken, but it is better.
The server tests all pass, but 3 of the client tests fail, I don't know why...

from todos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.