Comments (5)
If we decide it shouldbe different between windows and others, IMO it should just be suggested to use ROOT_URL=127.0.0.1 when running on windows, instead of changing how the actual code runs. Having it be different would make it more annoying for our experience, if we ever got a developer who worked on windows.
from meteor.
Ah got it, didn't see that when I first looked at the changelog (its a pretty hefty change log and obviously not finished so understandable)
That phrasing does make me still feel like I could force ROOT_URL=http://localhost so could use some fixing up. Also there is a typo as the url would be 127.0.0.1 not 127.0.1
from meteor.
Yes, we did that change, primarily because there was an issue with using localhost, with Node 16 > in Windows, from what I recall. We will do a revision on this, maybe this should only change for Windows.
from meteor.
Ah got it. I am personally fine with it switching, it would just need to be explicitly mentioned in a changelog. And I think it is worth it being the same across all platforms.
At first glance it just seemed like an unnecessary change that was breaking our testing experience.
from meteor.
It is being mentioned in the changelog:
meteor/docs/generators/changelog/versions/3.0.md
Lines 367 to 371 in a8dbcd7
You gave me a good idea. Run the windows tests exactly like you said, passing the argument ROOT_URL
.
from meteor.
Related Issues (20)
- [Meteor 3] Server-only Method displays "Method stub took too long" warning in browser console when using Meteor.callAsync HOT 3
- Underscore 1.6.0 `_.intersection` bug (Meteor package) HOT 1
- Vite config is parsed incorrectly HOT 2
- Error when installing package `jam:method` HOT 5
- `npm install -g meteor` has overly strict install requirements HOT 2
- Exception in onStop callback: TypeError: handle.stop is not a function HOT 3
- issue of auto compile which is not compiling the project locally HOT 3
- Cannot install dependency from the bundle about "source-map-support" from other nation
- [3.0] insertAsync on client won't persist local document HOT 2
- Underscore _.where function return only one item HOT 2
- Meteor.user() does not work in webApp connect handlers HOT 16
- 3.0-beta.6 > Create VueJs App > Cannot find module 'fibers' HOT 5
- Hot Reload with false-positive on Meteor 3.0 using module-resolver Babel plugin HOT 2
- Server HMR running with frontend changes
- [2.15] libcrypto.so.3 not found on CircleCI HOT 4
- Should Meteor.loginWithPassword have a promised-based alternative? HOT 3
- Meteor.loginWithPassword should have a similar signature as Accounts.createUser HOT 5
- Meteor 3: TypeError: Cannot read properties of undefined (reading βformatβ) HOT 2
- Missing Accounts.addEmailAsync
- Meteor 3.0-beta.7 not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor.