Coder Social home page Coder Social logo

Comments (5)

ToyboxZach avatar ToyboxZach commented on May 18, 2024 1

If we decide it shouldbe different between windows and others, IMO it should just be suggested to use ROOT_URL=127.0.0.1 when running on windows, instead of changing how the actual code runs. Having it be different would make it more annoying for our experience, if we ever got a developer who worked on windows.

from meteor.

ToyboxZach avatar ToyboxZach commented on May 18, 2024 1

Ah got it, didn't see that when I first looked at the changelog (its a pretty hefty change log and obviously not finished so understandable)

That phrasing does make me still feel like I could force ROOT_URL=http://localhost so could use some fixing up. Also there is a typo as the url would be 127.0.0.1 not 127.0.1

from meteor.

Grubba27 avatar Grubba27 commented on May 18, 2024

Yes, we did that change, primarily because there was an issue with using localhost, with Node 16 > in Windows, from what I recall. We will do a revision on this, maybe this should only change for Windows.

from meteor.

ToyboxZach avatar ToyboxZach commented on May 18, 2024

Ah got it. I am personally fine with it switching, it would just need to be explicitly mentioned in a changelog. And I think it is worth it being the same across all platforms.

At first glance it just seemed like an unnecessary change that was breaking our testing experience.

from meteor.

Grubba27 avatar Grubba27 commented on May 18, 2024

It is being mentioned in the changelog:

- Async local storage was added to help deal with async methods.
- Added `promiseEmmiter` to help with async methods.
- Removed `fibers` from package.
- `Meteor.absoluteUrl` in localhost uses `127.0.1` by default.
.

You gave me a good idea. Run the windows tests exactly like you said, passing the argument ROOT_URL.

from meteor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.