Comments (15)
We could also go one step further and move to TypeScript.
from blaze.
I think a good starting point for moving towards TS would be to add type definitions at least, so intellisense can pick it up better.
from blaze.
We could but I have no TS experience at all so to me it would take much more time to get into the ts thinking
from blaze.
Alright let's take it step by step.
from blaze.
I'm willing to do this.
I'm new to open source and this seems like a good issue to resolve. Is there anything that I must know about this project or anything else?
from blaze.
Great @rashmod !!!
Please do one PR per package (Thie repo contains multiple packages). Since you are new it may be a good start by using a smaller package.
Another thing that's still not discussed is which linter we use cc @StorytellerCZ @denihs
from blaze.
Okay, then I'll start with the smaller packages. But when you say convert to es6 are you just talking about changing the var
to let const
or anything more. I want to be more explicit about the scope of this thing before starting.
from blaze.
I woul say use const
and let
and all newer Methods from Object
/ Array
and String
that became available since ES6 (where applicable).
Also favour destructuring and named parameters incl. parameter defaults where applicable.
Note: arrow functions should be used with care since there are many binding going in Blaze with functions using this
a lot.
Don't worry, just start and we will review anyway. If there are things left to be improved etc. we will let you know and you will have enough support to get this done right
from blaze.
I will start working on this now. But @jankapunkt you were talking about the linter to use.....?
from blaze.
I just checked and the main Meteor project uses the @quave/quave config (see their package.json) which is maintained by @filipenevola so I think we should also adapt to use it.
What do you think @StorytellerCZ @denihs
from blaze.
No objection from me
from blaze.
I'm having some issues while setting up the local env. I used nvm to change to node v14.20.0 and somehow installed meteor (faced many problems with this too). But when following the steps in the readme meteor npm install
for setting local env I get the error saying package.json not found.
sidenote: my primary cli git bash does not work with meteor. "bash: meteor: command not found" even tho it works using PowerShell or cmd
from blaze.
I am unfortunately only on Linux and MacOS so I cannot be of much help regarding windows setup. Have you checked the Meteor forums about these issues? IIRC there should be a few solved topics on windows issues regarding installation of Meteor.
Can anyone else help out here?
from blaze.
The error I keep getting is that there is no package.json file. And according to my beginner-level understanding, you need a package.json to do npm install and stuff
from blaze.
You need to move into the test-app directory. It contains the package.json file. The contribution.md file covers the commands you can use there. This is to separate the test project from the packages.
from blaze.
Related Issues (20)
- blaze is missing `jquery` in its dependency list. HOT 6
- Handlebars syntax is not bad at all, we can make it faster than React, Vue, or Svelte HOT 5
- small issue with parsing html comments inside Blaze templates HOT 3
- ReferenceError: SpacebarsCompiler is not defined HOT 1
- Handle async code HOT 20
- Help developers by indicating undefined data in debug mode
- spacebars-tests packages still uses removed code
- Blaze.remove() destroys DOM before calling onDestroyed() HOT 8
- Error handling, callbacks and DOMRange HOT 9
- Errors in onCreated callback cause a complete stop for rendering further Templates
- Bootstrap select picker is not correctly removed / disposed during Template descruction HOT 6
- Add benchmarks to tests
- SSR is broken in 2.6.0 HOT 4
- Add ts types HOT 3
- Blaze compile errors completely silent if imported HOT 12
- Be able to have more contentBlock in template HOT 1
- Non-primitives not fully reactive in 2.7
- Complete GitHub community standards HOT 7
- CI/CD for documentaiton
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blaze.