Coder Social home page Coder Social logo

Remove "print mode" about angular-invoicing HOT 4 CLOSED

metaware avatar metaware commented on June 6, 2024
Remove "print mode"

from angular-invoicing.

Comments (4)

yaworsw avatar yaworsw commented on June 6, 2024

I think this comment from the hacker news thread sums up what I think should be done about "print mode"

I think the print mode button is valuable. It provides an affordance that shows you you can turn of the GitHub notice and footer, and use this for actual invoices. Lots of people don't know about print-only style sheets, and how many people are going to print-preview the page as opposed to click a button out of curiosity?
wikwocket@HN

So, I think print mode should stay since its a pretty good affordance tell the user "this page can be used to create invoices you can print", however I also think the @media print styles should be incorporated as you suggest.

from angular-invoicing.

Lambdanaut avatar Lambdanaut commented on June 6, 2024

That's a good point.
Yeah, I think it's a good idea to do both.

from angular-invoicing.

manpreetnarang avatar manpreetnarang commented on June 6, 2024

That's exactly what we are doing. We already have the noPrint class in the
css/style.css file. Very constructive feedback. Appreciate it.

Thanks guys!

On Fri, Aug 16, 2013 at 10:33 AM, Josh Thomas [email protected]:

That's a good point.
Yeah, I think it's a good idea to do both.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-22769320
.

from angular-invoicing.

jasdeepsingh avatar jasdeepsingh commented on June 6, 2024

Turns out we are already using this and the reasoning behind the Print Mode button is intentional.

Thanks for the feedback! Appreciate it. Closing this issue.

from angular-invoicing.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.