Specifying image sizes, image size by percentage about html2doc

[opoudjis]

Word documents have done:

if node["height"] == "auto" || node["width"] == "auto"
        attrs[:height] = nil
        attrs[:width] = nil
      end

This means that if only one size parameter of the image is specified, neither is making it to Word, and the document is being resized to full size. That behaviour needs to be suppressed.

This code dates from metanorma/metanorma-ribose#12 (comment) . I was right that Word would not understand height="auto", but the recalculation of the image size that takes place via Html2Doc if height=0 means it does not need to anyway.

[opoudjis]

Provide a "%" option to shrink size

Thought you'd just casually sneak a major feature addition in to an urgent bugfix ticket, did you?

No, this will not get actioned now. Demoted to medium priority.

[opoudjis]

Percentage will be recognised, and converted on preprocessing to pixel value. @alexeymorozov This doesn't affect you, right?

[opoudjis]

@alexeymorozov I'm moving image_resize(img, path, maxheight, maxwidth) and get_image_size(img, path) from html2doc to metanorma-utils anyway

[opoudjis]

Still working on this in isodoc...

[alexeymorozov]

@alexeymorozov I'm moving image_resize(img, path, maxheight, maxwidth) and get_image_size(img, path) from html2doc to metanorma-utils anyway

👍 The work doesn't intersect with vectory integration except of 1 line.

[alexeymorozov]

@opoudjis Would you like the image_resize methods also to be moved to vectory?

[ronaldtse]

@alexeymorozov that’s probably a good idea. Any vector image manipulation or attribute reading should be in vectory.

[opoudjis]

They are nothing to do with vectors, they apply to images generically. OTOH, you did move DataURI functionality to vectory as well, and that too is generic functionality. Don't care one way or the other...

[ronaldtse]

We might just extend Vectory to handle raster images as well...