Coder Social home page Coder Social logo

Comments (5)

georgewrmarshall avatar georgewrmarshall commented on September 26, 2024

@wachunei please add any additional information if needed

from metamask-mobile.

wachunei avatar wachunei commented on September 26, 2024

@georgewrmarshall No more additional information needed, the code + video is straightforward

from metamask-mobile.

brianacnguyen avatar brianacnguyen commented on September 26, 2024

@georgewrmarshall This is not a bug. When you remove the size variant of ButtonLink, it defaults to size Auto, which sets the ButtonLink to the inline auto size so the behavior you saw is 100% intended

from metamask-mobile.

georgewrmarshall avatar georgewrmarshall commented on September 26, 2024

@brianacnguyen as discussed in our 1:1 I'll defer to your decision to leave as is and close or update BottomSheetFooter to adjust the size of the ButtonLink during the mapping of the buttonPropsArray and whether it makes sense or might just complicate the component

from metamask-mobile.

brianacnguyen avatar brianacnguyen commented on September 26, 2024

Closed as ButtonLink is working as intended

from metamask-mobile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.