Coder Social home page Coder Social logo

Comments (1)

gantunesr avatar gantunesr commented on September 26, 2024

From a discussion with @owencraston,

  1. Replace all direct calls to the preferences-controller state (selectedAddress or identities) to either a selector or the useAccounts hook depending on the case. This should be also a good opportunity to add unit test in critical parts if they're missing.
  2. Resolve the inconsistency regarding importTime between the data type in the accounts-controller and preferences-controller. The easiest option is to use the preferences-controller data. Important to take into consideration a similar approach as extension of blocking the user of adding duplicated accounts
  3. Change the preference-controller selectors to accounts-controller selectors (selectSelectedAddress or selectIdentities).

Considerations,

from metamask-mobile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.