metamask / eth-token-tracker Goto Github PK

Documented in MetaMask/metamask-extension#2162

All the script entries should use yarn in place of npm for consistency.

e.g.:

Depends on:

• MetaMask/eth-block-tracker#180
  • MetaMask/eth-block-tracker#174

Token.js uses ethjs, but it is not added as a dependency.

This project is missing a CODEOWNERS file

Following our other libraries, we should add Jest and Jest configuration from the module template and convert the tests to Jest.

This project has some GitHub workflows but they are not up to date with the module template. We should make sure they are up to date.

Depends on

• #111
  • #110
    • #108
  • MetaMask/eth-block-tracker#180
    • MetaMask/eth-block-tracker#174

Following our other libraries, we should lint and format this project with ESLint/Prettier.

• Add our ESLint packages as dev dependencies (minus TypeScript and Jest)
• Add ESLint configuration file
• Add Prettier as dev dependencies
• Add Prettier configuration file
• Add @metamask/auto-changelog as dev dependency
• Fix any lint violations with changelog (also see #51)
• Add lint and lint:* package scripts

After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:

• Calling sendAsync will be deprecated; we should use request instead.
  • Currently, we only have a reference to sendAsync in the tests.
• Because this library is still written in JavaScript, we should also add the new version of @metamask/eth-json-rpc-provider as a peer dependency to enforce that EthTokenTracker takes this new type of provider.

This project should have an .nvmrc file

Following our other libraries, we should copy the TypeScript configuration from the module template and convert this library to TypeScript, using tsup to create CJS- and ESM-compatible builds.

We can then drop Browserify and Babel as dependencies.

LINK https://etherscan.io/address/0xb513898affad3dad3df23561a259bf6ed4eb1e0c#code#L1

The token tracker doesn't emit the update event after the first update if the balance of all tokens is zero. This is because it only emits the update event if the token balance has changed, and each token balance is initialized with a balance of zero.

Roll out non-breaking maintenance updates before dropping nodejs v12 support.

Blocked by

• #94
• #95
• #96
• #98

For consistency across project, we should switch this project to use Yarn

The CHANGELOG.md file currently doesn't link to any of the tags. The links should be added.