Got report that requesting access to private maps isn't working. about metamaps

[devvmh]

Do you know when it was? I can pull the logs

[devvmh]

Here's one session

<ip address> - - [02/Oct/2018:11:31:07 -0400] "GET /maps/3643/request_access HTTP/2.0" 302 91 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"<ip address> - - [02/Oct/2018:11:31:07 -0400] "GET /login HTTP/2.0" 200 8377 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:09 -0400] "GET /undefined HTTP/2.0" 404 1403 "https://metamaps.cc/login" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:14 -0400] "POST /login HTTP/2.0" 302 86 "https://metamaps.cc/login" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:15 -0400] "GET / HTTP/2.0" 200 21190 "https://metamaps.cc/login" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:16 -0400] "GET /assets/exploremaps_sprite-8586b240f331e428cfec6edf947097c859cf45182a30fbe35b79fae6ac78935b.png HTTP/2.0" 200 3162 "https://metamaps.cc/assets/application-3c8a3bd510d731d8b8f0ea69b9f9c232ced0105d6e14aa4d5d65ba1b6834b1d9.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:21 -0400] "GET /assets/metadata-005fb96a689c883d6fc4ff3f451a99cf6415b83457a6345f1ce24a0ed6371c80.png HTTP/2.0" 200 1540 "https://metamaps.cc/assets/application-3c8a3bd510d731d8b8f0ea69b9f9c232ced0105d6e14aa4d5d65ba1b6834b1d9.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:36 -0400] "GET /maps/3643/ HTTP/2.0" 200 25483 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:39 -0400] "GET /maps/3643/contains.json HTTP/2.0" 200 67467 "https://metamaps.cc/maps/3643/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:42 -0400] "GET /assets/screenshot_sprite-b511e90491f8271741f4f0c972c19f85db8baca3e019a4e1f62fae0071501e04.png HTTP/2.0" 200 1556 "https://metamaps.cc/assets/application-3c8a3bd510d731d8b8f0ea69b9f9c232ced0105d6e14aa4d5d65ba1b6834b1d9.css" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"
<ip address> - - [02/Oct/2018:11:31:50 -0400] "GET /search/mappers?term=an HTTP/2.0" 200 9960 "https://metamaps.cc/maps/3643/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36"

[Bortseb]

around 3 AM this morning

…

On Tue, 2 Oct 2018 at 11:50, Devin Howard ***@***.***> wrote: Do you know when it was? I can pull the logs — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1179 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABis6p-r-piv0TtTqK_jU-s9QVpzuOLQks5ug4tAgaJpZM4XETK4> .

[devvmh]

yeah, that's the one then. You can see the URLs they hit... I'll see if I get time this evening to look.

Not sure if the GET /undefined is relevant or not.

[devvmh]

geez, i can replicate this at https://metamaps.cc/maps/3643/request_access, the button just doesn't work

[Bortseb]

ok, that would explain why I as the map creator never got an email/notification about the request.

…

On Tue, 2 Oct 2018 at 11:58, Devin Howard ***@***.***> wrote: geez, i can replicate this at https://metamaps.cc/maps/3643/request_access, the button just doesn't work — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1179 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABis6rQdxUi17VscLS33WDUTLBmc_3FOks5ug40fgaJpZM4XETK4> .

[devvmh]

OK, so the relevant code for that button is here https://github.com/metamaps/metamaps/blob/develop/app/views/maps/request_access.html.erb#L22

I can see that the script tag is loaded on the page, but either

a) it's not executed, or
b) the click handler is later cleared by other code

no AJAX request is made when the button is clicked (and the text doesn't change) which is how I know the code isn't being executed.

[devvmh]

OK, I can confirm that the click handler starts out working, and something clears the event. if I'm debugging correctly, it looks like the actual elemnent itself is replaced. not sure why this is happenening; I suspect something to do with React