Comments (9)
Hi! Thanks for opening the issue. :)
We would be glad to see a PR for that because for us it will be hard to verify since we do not have arm64 archs.
from csi-driver-lvm.
The good news the code can be compiled to arm7 and arm64 with a tiny change.
One problem is I do not have much experience with the make tool and another issue would should all the supported platforms be part of the CI/CD? I might do the initial testing and modification if time allowed, but I do not know how to add arm hardware for CI/CD if it is required.
from csi-driver-lvm.
What are the required code changes to make it compile under arm7/arm64 ?
from csi-driver-lvm.
diff --git a/pkg/lvm/nodeserver.go b/pkg/lvm/nodeserver.go
index 7a8f2fa..2efc2b4 100644
--- a/pkg/lvm/nodeserver.go
+++ b/pkg/lvm/nodeserver.go
@@ -269,8 +269,8 @@ func (ns *nodeServer) NodeGetVolumeStats(ctx context.Context, in *csi.NodeGetVol
return nil, err
}
- diskFree := int64(fs.Bfree) * fs.Bsize
- diskTotal := int64(fs.Blocks) * fs.Bsize
+ diskFree := int64(fs.Bfree) * int64(fs.Bsize)
+ diskTotal := int64(fs.Blocks) * int64(fs.Bsize)
inodesFree := int64(fs.Ffree)
inodesTotal := int64(fs.Files)
from csi-driver-lvm.
This can only be true for arm7, because im almost sure on arm64 fs.Bsize is int64 already.
from csi-driver-lvm.
That is true. The wording is not precise since the issue is to support both arm64 and arm (arm7).
from csi-driver-lvm.
If you mind sending a PR, im happy to review
from csi-driver-lvm.
Hi, there have sent a PR, anyone up for a review?
from csi-driver-lvm.
Hi
The latest tagged v0.4.0
images do not have arm nor arm64 images available. Only the latest tag had them
lvmplugin tags
from csi-driver-lvm.
Related Issues (20)
- State of the project? HOT 2
- Not deleting pvc with claim policy = Delete on pod termination HOT 2
- helm install CSIDriver.spec validation error HOT 4
- Resize failing despite free VG space HOT 2
- Multiple deprecatation warning during deployment
- How to limit nodes that cdi-driver is trying to provision a volume to? HOT 2
- [Enhancment] Support for LVM-HA HOT 5
- Kubernetes 1.22 and v1beta1 versus v1 HOT 4
- unable to activate logical volumes: Volume group "csi-lvm" not found HOT 2
- PVCs pending with WaitForFirstConsumer on fresh install HOT 5
- Dockerfile dependency packages questions HOT 8
- chmod 0777 causes recursively setting volume ownership even with fsGroupChangePolicy: OnRootMismatch HOT 2
- [new feature request] add clone volume function HOT 2
- Feature Request: hashicorp nomad support HOT 4
- /etc/lvm/archive not mapping, possible data loss HOT 2
- Read-only filesystems are not supported HOT 4
- Operator documentation + resize + adding new volumes HOT 2
- Provisioner pod created in default namespace HOT 8
- Helm installation from README doesn't work
- Does not start on >= kubernetes v1.27.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csi-driver-lvm.