Coder Social home page Coder Social logo

Comments (2)

crisptrutski avatar crisptrutski commented on July 3, 2024

I see this compilation uses QP directly, so we will need to do something smarter. Unfortunately we cannot insert comments within the tag-default values. Perhaps we need a flag to QP to inject these on our behalf.

from metabase.

crisptrutski avatar crisptrutski commented on July 3, 2024

I can't remember what I was thinking when I opened this, but I suspect I was just confused by the fact that analysis uses QP compilation. Replace does not reuse the same analysis wrapper, and does reverse its modifications already. Pushing down replacements would still be a nice optimization, but the behavior we want is already captured in passing tests.

from metabase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.