Coder Social home page Coder Social logo

Comments (13)

evanmj avatar evanmj commented on August 18, 2024

Zoom buttons would be excellent if there is a decent way to add that at the css level or using viewport settings or what have you. +1 for this feature req :)

from muximux.

mescon avatar mescon commented on August 18, 2024

I'll see what I can cook up. Do you think the zoom should be a setting on the settings view?

from muximux.

evanmj avatar evanmj commented on August 18, 2024

I would think either a hotkey or (if enabled) a tiny plus and minus icon on each side of the tab maybe? Theoretically having it remember the setting would let you add it to the settings of the item, which would be good enough. In essence you'd be setting zoom for each tab relative to "no zoom", so 0.9 or 1.1, etc.

from muximux.

mescon avatar mescon commented on August 18, 2024

Well, doing it in a hotkey would basically make it into the same thing the browser already does, so I don't exactly see the point of it... or am I missing something?

from muximux.

evanmj avatar evanmj commented on August 18, 2024

The browser hotkey (Ctrl + and Ctrl -) zooms the entire dash, making the tabs themselves get larger and smaller as well as the content within them. Breaking that functionality would be bad, but I'm thinking maybe ctrl-alt + (if possible to bind to that) would zoom only that tab. I imagine you could do that with a bit of css or with the viewport setting (sorry, I don't have much web dev experience).

Even just having a new field on the 'setting block' for each tab that the user could put in a % zoom would be great to sort of 'normalize' the views. I run zoneminder on mine and (due to problems with the zoneminder UI), the console needs zoomed way in, but the live video feeds need zoomed way out, so with different tabs with individual zoom factors I could have it all just right.

Hopefully that clears up my comments.

from muximux.

mescon avatar mescon commented on August 18, 2024

There is still a bug in webkit-browsers whereby the viewport size extends further than the actual contents of the iframe, causing a scrollbar - though only when the scale is less than 100%. I have yet to able to work out exactly what the problem is.

from muximux.

mescon avatar mescon commented on August 18, 2024

Would somebody be willing to switch to the develop branch and test this out?
Perhaps if any of you have any ideas for how to fix the bug in webkit-browsers?

from muximux.

mescon avatar mescon commented on August 18, 2024

Nevermind - found the problem and fixed it. Pushed to develop branch.
I'll close this issue now, as this is currently live in develop which will be merged to master when a couple of more things has been fixed.

from muximux.

evanmj avatar evanmj commented on August 18, 2024

Thanks, I'll try to test it tonight.

from muximux.

evanmj avatar evanmj commented on August 18, 2024

Pulled e6dad15 from Develop and tested just now.

All zooms defaulted to 10% in the settings menu and the settings.ini.php file (should probably be 1.0, not 0.1).

After saving and reloading from the settings gui, the settings.ini.php file is updated, however the next time you open the settings gui, it defaults all settings back to 10%. (It seems like it is not pulling this data from the file properly and displaying on the settings page).

I did get everything working by manually typing in the zoom percentages in the settings.ini.php manually, and it works really well.

from muximux.

evanmj avatar evanmj commented on August 18, 2024

Disregard last comment. Here is a better description of the problem:

When upgrading, scale in the settings.ini.php file defaults to 0.1, it should default to 1.0.

I tried adding an item in settings, but the zoom section did not show up on new tabs, just ones that already existed. Once a tab is created and then you go back into settings it shows the zoom level.

One other thing to consider, maybe i++ should be i+=5... I think 5% increments should due just fine and make for less scrolling to select the zoom level. If a user needs 37% (for instance instead of 35%) they could simply edit the settings file manually.

from muximux.

mescon avatar mescon commented on August 18, 2024

Blast!
I was unsure how this would handle... I'll try and rewrite some stuff and see if I can get it fixed.
It's losely tied together with our efforts to remove legacy code for parsing the settings file and instead use Config_Lite.

When I've made some progress on this I'll let you know and see if you could test it out for me.

from muximux.

mescon avatar mescon commented on August 18, 2024

Fixed this.

from muximux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.