Comments (4)
This appears to be an issue with the way the mythic passive is formatted on the wiki. There's no existing stat defined for % hp bonuses, so Heartsteel's mythic is just defined as [spec]
. I'm working with the wiki team to see if we can get a % hp bonus stat defined, which would then require updates to the parsing code to pick it up.
from lolstaticdata.
After speaking with the wiki team, they don't want to create a new stat for %hp bonuses since Heartsteel is currently the only item that has one. The compromise we reached was to edit the mythic bonus in the wiki's item data module like so:
["mythic"] = {
["hp"] = "1%",
["spec"] = "6% increased [[size]]",
},
That leaves us with the problem of how to convert that 1% string to a passives.stats.health.percent
value. I've been looking through the parsing code, and I'm not sure where's the best place to do that. Any ideas @jjmaldonis?
from lolstaticdata.
Hey, I don't have my head in this right now. At the end of the day we will not be able to represent the entirety of the complexity of the items in this JSON, which means that some manual effort will be required by anyone who wants to use this JSON to represent items in their code.
This may be one of the unfortunate cases where user intervention is required. If the wiki team isn't willing to create a new stat then we may be out of luck for the time being.
After looking into the details of what this new item does, it is infeasible to represent what it actually does using just the JSON. The calculation for this part of the passive will have to be done using user intervention. So I don't think it's particularly important that we represent this information accurately in the JSON. In fact, representing this information in the current JSON structure may be misleading to someone who is only reading the JSON.
from lolstaticdata.
To be clear, I'm just referencing the mythic 1% hp bonus, which is a typical mythic passive and does fit nicely in the JSON as currently structured: passives[1].stats.health.percent: 1.0
. We just need to capture the value from the wiki. The mythic size bonus and the stacking hp passive are obviously more difficult to represent in the JSON as it stands, if at all.
I'll dig a little deeper and see if I can solve the %hp bonus. Thanks for the reply.
from lolstaticdata.
Related Issues (20)
- Inconsistent use of underscores and camelCase in served JSON HOT 4
- [HELP] Some manual way to check champion data HOT 1
- Add map availability to items.json
- Add item classification (e.g. starter, legendary, epic) to items.json
- Item movespeed passives aren't being parsed/structured correctly HOT 4
- Discussion: Percent vs Flat values for stats that stack additively (critical strike chance, lifesteal, omnivamp) HOT 2
- What is the intended way to read/parse item effects? HOT 1
- CDN not updated HOT 3
- Small stats differences with dataDragon HOT 1
- Echoes of Helia missing HOT 1
- Missing 'Ornn' as the required Ally/required_ally HOT 2
- Some chroma entries are "null" HOT 2
- Missing version 12.20 in patches json file
- i want to use http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/champions.json HOT 1
- champion/*: Missing champion data for Hwei and Smolder HOT 1
- Potential Data to add
- Inconsistent Schema HOT 1
- Some Champion Skin Loading Screen splash arts do not have valid URLs HOT 2
- Heartsteel item is missing in the JSON cdn
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lolstaticdata.