Comments (3)
I've done some investigation and it looks like the value for 'User-Agent' key for the websocket request from Safari iOS is longer than the 128 characters specified on line 634:
const int ValueBufSize = 128;
Raising this value is one solution, however it's worth noting that the current logic bails out of the entire connection if a value is longer than this. Given that the User-Agent key is not read anyway, it might be best to change the logic from 'break' to 'continue'
from websocket.
problem is at line 658, comment it out and problem goes away for me, it looks like code to fix some buggy client, it causes val_len on line 695 to have -1
`
658 while (val_end[-1] == ' ') val_end--;
695 if (val_len >= ValueBufSize) break;
`
this is my connection string
GET / HTTP/1.1
Host: localhost:1234
User-Agent: Mozilla/5.0 (Unix; U; Linux 6.3.5-200.fc38.x86_64) http/2.9.5 Tcl/8.6.12
Connection: keep-alive
Upgrade: websocket
Connection: Upgrade
Sec-WebSocket-Key: cZ7A+m2Pl1zuGlE1AcmnDA==
Sec-WebSocket-Version: 13
Sec-WebSocket-Protocol:
Accept: /
Accept-Encoding: gzip,deflate,compress
from websocket.
Relaxed some http header validations, please check the latest commit.
from websocket.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from websocket.