Coder Social home page Coder Social logo

Comments (5)

mikljohansson avatar mikljohansson commented on August 14, 2024

Very sorry to hear that!

The first sentence of the readme does say "This image will periodically clean up exited containers and remove images and volumes that aren't in use by a running container." but that might not be enough. Perhaps we should include more of a warning like https://github.com/chadoe/docker-cleanup-volumes does, highlighting what the container will do?

from docker-cleanup.

Mrono avatar Mrono commented on August 14, 2024

It happens, not upset.

I installed via the rancher catalog, which may not have that warning (still my fault for not investigating it more). The issue is that the cleanup doesn't make a distinction between stopped containers, and stopped data-only containers.

from docker-cleanup.

mikljohansson avatar mikljohansson commented on August 14, 2024

I've added a warning in bold text to the readme, let's hope others don't end up with the same issues.

When using exited containers to hold data I think this cleanup image might not be the best thing to have running in a cluster, even if carefully excluding them with $KEEP_CONTAINERS. Since it could be prone to mistakes and wipe out valuable data.

Didn't know that this image was in rancher catalog, is that a curated repository and where could I find it? (Google didn't help much in finding it..)

About data-only containers, is there a way to distinguish them from regular existed containers?

from docker-cleanup.

Mrono avatar Mrono commented on August 14, 2024

https://github.com/sshipway/rancher-catalogue/tree/master/templates/janitor

from docker-cleanup.

mikljohansson avatar mikljohansson commented on August 14, 2024

Interesting, will take a closer look. In any case, thanks for reporting this

from docker-cleanup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.