Ethereum message signature V issue about trezor.net

[juanfranblanco]

ha ha it happens to me the same, and monitoring so many repos is a nightmare.. gitter is my main point of contact if I am not in the zone :)

[juanfranblanco]

Yes this is all working now :)

[MelbourneDeveloper]

@juanfranblanco the problem is because the code is a literal translation from Java:

I'm investigating...

[juanfranblanco]

After removing the -1 it works, I have not seen any changes on behaviour.. although I have not tested thoroughly. Nevertheless that seem to do the trick. On the other scenario it was copying the penultimate byte, so you had a duplicate.

[MelbourneDeveloper]

You mean this one here, or both?

[MelbourneDeveloper]

This is confusing because in Java the array is indexed differently I think,

[juanfranblanco]

Yes that one :)

[MelbourneDeveloper]

Are you able to do a pull request with your test? i.e. put a test for your transaction signing in?

[juanfranblanco]

Yes that was the plan, I am trying to fix transactions at the moment. The signature is not correct.

[MelbourneDeveloper]

I'm just testing on Android and will check in the fix.

[MelbourneDeveloper]

The fix is in this NuGet:
https://www.nuget.org/packages/Trezor.Net/2.2.0

I can see why it went wrong now. It was a copy pasta mistake.

[MelbourneDeveloper]

Let me know if this fixes it for you.

[juanfranblanco]

Oh I am working on the Trezor.Net source, so I can debug and tinker :)

[MelbourneDeveloper]

No problem. It's committed in master.

[MelbourneDeveloper]

Btw sorry about the slow response. I never get notifications about new issues. Best to email me if something is wrong.

[MelbourneDeveloper]

@juanfranblanco this fix has actually solved a problem in the KeepKey library which is based on Trezor.Net. So, thanks. Can this ticket be closed now? Do you suspect there are other issues in reading and writing data to the Trezor? Have you seen #10 ?