Coder Social home page Coder Social logo

Comments (9)

dureuill avatar dureuill commented on July 1, 2024 4

Hello,

we found a fix, see #4707 for details

Considering the impact of this issue, we'll be releasing the fix in:

  • a patch release for v1.8, and
  • the next RC for v1.9

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024 2

Some progress in the investigation, thanks to the work of users in the Discord.

  • it looks like vm.map_count increases without decrease
  • the increase in maps is also accompanied by a memory increase that looks like a memory leak
  • the error message alternate with an unrecoverable panic while setting the stack guard page
  • confirmed to be a 1.8 regression

@irevoire has been trying to reproduce the issue on our end, more information about whether that attempt was successful to follow today.

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024 2

Hello @iamriajul, you can also downgrade to v1.7.6 which doesn't exhibit this behavior (v1.8 regression) but still has much better performance and a lot more features than v1.3.5

We're trying to understand the cause of the regression in v1.8. It looks like a memory leak indeed.

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024 1

Some news on this issue:

  • @irevoire managed a reproduction of the leak on Meilisearch v1.8.0 and checked there was no reproduction in v1.7.6
v1.8.0, number of memory maps according to time v1 8 0
  • The number of maps is linear in time.
  • At the time the machine was stopped it had reached around 16k maps
v1.7.6, number of memory maps according to time

v1 7 6

  • The number of maps is constant in time
  • it hovers around 400 maps
  • @irevoire tested with a downgrade of charabia from v0.8.10 to v0.8.7 (the version it was in v1.7.6). It seems to fix the leak. We're now investigating the source of the memory leak in charabia
v1.8.0 with downgraded charabia, number of memory maps according to time

v1 8 0 with downgraded charabia

  • The number of maps is constant in time
  • it hovers around 400 maps

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024 1

⚠️ There was a setup issue in the previous test campaign; the leak is still present with charabia v0.8.7 and so was not introduced by charabia v0.8.10.

Continuing investigation...

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024

Next steps:

  1. try and reproduce the issue to further debug with debug builds and hooks

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024

https://github.com/orgs/meilisearch/discussions/677#discussioncomment-9562242 could also be related

from meilisearch.

iamriajul avatar iamriajul commented on July 1, 2024

https://github.com/orgs/meilisearch/discussions/677#discussioncomment-9562242 could also be related

Thanks, I found this. Recently after a server migration, I migrated meilisearch to 1.8.1 from 1.3.5 and then nightmare started, I couldn't find the reason, then suspected docker resources limit issue (#4686) but after few days today meilisearch crashed again!!! So this saved me, by just downgrading to 1.3.5.

from meilisearch.

dureuill avatar dureuill commented on July 1, 2024

Fixed in v1.8.3

from meilisearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.