Comments (9)
Hello,
we found a fix, see #4707 for details
Considering the impact of this issue, we'll be releasing the fix in:
- a patch release for v1.8, and
- the next RC for v1.9
from meilisearch.
Some progress in the investigation, thanks to the work of users in the Discord.
- it looks like
vm.map_count
increases without decrease - the increase in maps is also accompanied by a memory increase that looks like a memory leak
- the error message alternate with an unrecoverable panic while setting the stack guard page
- confirmed to be a 1.8 regression
@irevoire has been trying to reproduce the issue on our end, more information about whether that attempt was successful to follow today.
from meilisearch.
Hello @iamriajul, you can also downgrade to v1.7.6 which doesn't exhibit this behavior (v1.8 regression) but still has much better performance and a lot more features than v1.3.5
We're trying to understand the cause of the regression in v1.8. It looks like a memory leak indeed.
from meilisearch.
Some news on this issue:
- @irevoire managed a reproduction of the leak on Meilisearch v1.8.0 and checked there was no reproduction in v1.7.6
v1.8.0, number of memory maps according to time
![v1 8 0](https://private-user-images.githubusercontent.com/41078892/340629848-1a36b42e-6f91-4339-b8f6-d1bc0beff2ab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NzM0MDQsIm5iZiI6MTcxOTc3MzEwNCwicGF0aCI6Ii80MTA3ODg5Mi8zNDA2Mjk4NDgtMWEzNmI0MmUtNmY5MS00MzM5LWI4ZjYtZDFiYzBiZWZmMmFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDE4NDUwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlYTZiODBkNGJiOTM2YWJkMTZlNzUzYjAzZTRlZjA5NmMyYmI0NWE1MzRiZDU5NzgwZTliOTRlZTBiM2M3NjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bgM0oooMXsedAY9yoMMfnVCOk9Doe-zBvGf07zM7QmM)
- The number of maps is linear in time.
- At the time the machine was stopped it had reached around 16k maps
v1.7.6, number of memory maps according to time
- The number of maps is constant in time
- it hovers around 400 maps
- @irevoire tested with a downgrade of charabia from v0.8.10 to v0.8.7 (the version it was in v1.7.6). It seems to fix the leak. We're now investigating the source of the memory leak in charabia
v1.8.0 with downgraded charabia, number of memory maps according to time
- The number of maps is constant in time
- it hovers around 400 maps
from meilisearch.
Continuing investigation...
from meilisearch.
Next steps:
- try and reproduce the issue to further debug with debug builds and hooks
from meilisearch.
https://github.com/orgs/meilisearch/discussions/677#discussioncomment-9562242 could also be related
from meilisearch.
https://github.com/orgs/meilisearch/discussions/677#discussioncomment-9562242 could also be related
Thanks, I found this. Recently after a server migration, I migrated meilisearch to 1.8.1 from 1.3.5 and then nightmare started, I couldn't find the reason, then suspected docker resources limit issue (#4686) but after few days today meilisearch crashed again!!! So this saved me, by just downgrading to 1.3.5.
from meilisearch.
Fixed in v1.8.3
from meilisearch.
Related Issues (20)
- Internal document id don't do the difference between string and integer HOT 1
- Improve the tenant token error message
- Error while generating embeddings: user error: attempt to embed the following text in a configuration where embeddings must be user provided HOT 13
- Confusing matches in `_matchesPosition` when using phrase search HOT 2
- Tracking issue: Road to Vector store stabilization
- Allow custom headers in REST embedder configuration
- REST API parameter names and behavior are unclear
- Prepare `/similar` for stabilization, or create a new experimental feature for the `/similar` routes
- Review all error codes before stabilization
- Consider a more explicit behavior to designate the default embedder
- Reconsider the failure of the indexing process when a document doesn't explicitly declare its embeddings for a `userProvided` embedder.
- Make the `embeddings` parameter optional when specifying your embedder HOT 1
- Tasks stuck in `processing` state, lots of tasks HOT 1
- Incorrect `_matchesPosition` returned, cuts into a UTF-8 character HOT 1
- Hybrid search don't skip offset results when the keyword results are returned early HOT 1
- Federated search
- Tasks processing seems to block at some point
- Language settings
- Document DB compression
- Exp - Update documents with a function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meilisearch.