Comments (7)
I would like to see if I can work on this issue, would that be ok?
from meilisearch.
Hello @tacman
Thank you for this report.
This would be a nice improvements
Any contribution is welcome ❤️
This issue is not hard, but not trivial. Knowledge in Rust are required.
It will probably mean a lot of small mechanical changes to multiple files.
We would probably want the added context for most if not all milli::UserError
. The thing is that in this location of the engine, we don't have the information of the index name.
So it would have to be injected at the point where the error is caught in the webserver part of the engine, which will be many different points depending on where we're calling milli functions that can error
from meilisearch.
Perhaps the change could be make in the meilisearch php library?
from meilisearch.
We would rather handle this at the source (engine) than changing things in 10 library
from meilisearch.
Makes sense. In addition to the index, I guess it'd be helpful to have all the details. Sometimes I run meilisearch in docker, and in different projects it listens on different ports, and sometimes calls a remote server. So in addition to the index, I'd want to know the server and port.
from meilisearch.
We would rather not prioritize the port addition to solve this issue -> let's focus on the index name as a first step. From a product perspective, it does not seem relevant to us to have this information in the error, so we need more product discussion before validating it. We are a small team so we are careful about everything we add because can be tedious to update and maintain
Btw, as a workaround, in the meantime you can have all the information in the URL you try to reach: index name and port
from meilisearch.
Hello @cisco877
Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!
For your information, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.
We are looking forward to reviewing your PR 😊
from meilisearch.
Related Issues (20)
- [EXPERIMENTAL] Update the console log level at runtime HOT 1
- Update cargo.toml version for v1.8.0
- Logs should be outputted to `stderr` instead of `stdout` HOT 1
- Implement changes for Replication HOT 1
- Negative operator HOT 2
- Make `sortFacetValuesBy` work with `/facet-search` endpoint
- Modify facet-search sort at query time HOT 1
- Meili search ignore offset in request. Always start with 0 in response HOT 2
- Problem Searchable & Unsearchable with v1.6.1 & v1.6.2 HOT 12
- run failed with win 11 HOT 7
- Need Help - Touches Relationships Laravel scout & meilisearch HOT 2
- Make the processing of batches atomic HOT 1
- Task Queue: Decorelate the tasks from their details / errors
- Webhooks parsed with no content-type HOT 2
- Just for some queries: MDB_CORRUPTED: Located page was wrong type. HOT 8
- Meilisearch silently fails to index new documents: no logging, no meaningful response HOT 3
- Determine if positional databases should be optimized
- CI failing with `--no-default-features` HOT 4
- Task panicked in multi-search HOT 7
- Missing embeddings after importing a dump HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meilisearch.