Comments (6)
Hi @shivaylamba!
I just made a PR to try and figure out what was the problem. I think I figured it out.
The difference between the tenant-token demo
and all the other demos in Vercel
is that the tenant-token
demo is using environment variables stored in Vercel
.
So as a security, any commit not coming from a Vercel
member of the tenant-token
project is by default not authorized to deploy a preview.
I think you can disable this security behavior in your Vercel
project in /settings/security
. You will find a section Git Fork Protection
.
Also, I would advise you to set up specific environment variables for Production
, Preview
and Development
.
Let me know if this is not clear, if you need more information or if this fixes your issue! 😄
🦭
from demos.
Hey @meilisearch/devrel-team, did it fix your issue?
from demos.
no idea, do you @shivaylamba ?
from demos.
This should be fixed, since I followed the steps as suggested by @nicolasvienot to configure the setting in Vercel for the project.
from demos.
Hi @meilisearch/devrel-team,
After a talk with @CaroFG I wanted to get back to this issue and the way we handled it.
Be aware that disabling the Git Fork Protection
on Vercel might cause security issue if you have the same environment variables in your preview
, staging
and production
environment.
It means that anyone can trigger a deployment in Preview mode
by creating a PR in this repository, and this PR will have access to your environment variables. If there is any sensitive information there (Meilisearch master key or private key for example), you should either only use them in production or find another way to handle them. Let me know if you need any help with that.
from demos.
cc @shivaylamba @oluademola
I let you all and @CaroFG handle this, it's out of my expertise area
from demos.
Related Issues (20)
- CSS theme: make buttons adapt to text size
- CSS theme: make magnifying glass visible
- Ecommerce deployment failed due to linter error
- Remove design system link from css theme readme
- Add `where2watch` demo HOT 3
- Correct environment variable name on matching strategy demo
- Adding a link to Matching Strategy documentation in the Matching Strategy demo HOT 3
- Add ecommerce demo to README list
- Update demos README to match lock file HOT 1
- Remove Slack mentions in READMEs HOT 1
- Add matching strategy demo to README list
- Add pagination demo to README list
- Bug in geosearch Demo
- Add federated search demo in Readme
- Add guide column to feature showcase demos
- Remove .DS_Store in src directory HOT 2
- Avoid redeploying all demos every time a change is made in the src directory HOT 9
- Add Vercel process
- e-commerce deploy fails on Vercel HOT 1
- Add a .gitignore file in the base directory HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from demos.