Coder Social home page Coder Social logo

Comments (5)

talonchandler avatar talonchandler commented on August 29, 2024

Actually...just pinning and releasing in waveorder doesn't fix the issue since existing versions of recOrder will install opencv too. We may need to consider pinning the version in recOrder too.

from waveorder.

talonchandler avatar talonchandler commented on August 29, 2024

The build just completed (roughly 35 minutes), and it seems to be working. I'll test more this afternoon.

As expected, the long build only needed to happen once, so subsequent reinstallations are fast.

I still need to test and think about the best plan...input welcome.

from waveorder.

ziw-liu avatar ziw-liu commented on August 29, 2024

We may need to consider pinning the version in recOrder too.

RecOrder at the main branch does not depend on OpenCV anymore (mehta-lab/recOrder@e68aaab). Since recOrder 0.2.x pins waveorder to 1.0.0rc0 anyway and 0.3.0 will be released without the OpenCV dependency, I guess this is not a big issue?

from waveorder.

ziw-liu avatar ziw-liu commented on August 29, 2024

That being said, I think we should remove OpenCV for waveorder too. The only function that uses it is not tested, and confusingly written. I can make a quick fix or removal if that sounds good.

Edit: the function is used locally in the viewer, should be easy to test.

from waveorder.

talonchandler avatar talonchandler commented on August 29, 2024

Okay great, thanks Ziwen. I'll go ahead and upload the release, since this is at worst an inconvenience.

from waveorder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.