No projects listed when whitelist is empty about atom-project-plus

[mehcode]

Would you agree that if the whitelist is empty, no whitelist behaviour should occur?

Definitely. This is a bug.

@shemerey ?

[mehcode]

@XanderXAJ I can't reproduce this. If you can reproduce this again, can you open the developer tools View -> Developer -> Toggle Developer Tools and run atom.config.get("project-plus.folderWhitelist") and atom.config.get("project-plus.folderBlacklist") in the console?

[XanderXAJ]

Sure thing. I cleared the whitelist config, ensured the issue was reproduced, then ran the following:

atom.config.get("project-plus.folderWhitelist")
""
atom.config.get("project-plus.folderBlacklist")
""

[shemerey]

@XanderXAJ @mehcode I don't have windows, but it looks like a bug will install Windows in VM and check this out, fix should simple :)

[mehcode]

If not I can test this on Windows (didn't even think about the OS; heh) at work tomorrow. I have Windows 10 on another partition.

[shemerey]

@mehcode @XanderXAJ yes it's defiantly a bug, minimatch doesn't recognize " " on Windows properly

[mehcode]

@XanderXAJ Please update to 0.7.2 and let us know if this is still a problem.

[XanderXAJ]

Thanks @mehcode @shemerey, I'm now getting all projects listed! :)

If this is a problem with minimatch, consider raising an upstream bug?

[mehcode]

We were essentially doing this:

minimatch.filter('{,/**,}')("project/path")

... for each path in your project. If the whitelist was an empty string. If I was the maintainer of minimatch I'd tell us to fix our usage. It's an odd thing that it didn't error on linux; it doesn't even look valid.

[XanderXAJ]

Fair enough! I hadn't gotten around to looking at the underlying code. Thanks for the explanation — and the fix!