Multi-thread trigger assertion about bosphorus

[msoos]

Hi,

Thanks! Is this related to this? https://github.com/meelgroup/bosphorus/issues In other words, does that PR fix this bug or it causes this bug? I understand that this needs fixing, but want to understand first how to reproduce.

Cheers,

Mate

[Flash-LHR]

This issue has nothing to do with pr.

Pr only sets the number of threads of cryptominisat5. Before pr, the number of threads of cryptominisat5 is always 1 regardless of whether the user specifies the thread parameter. In fact, I did not attempt to fix the above assertion failure.

I have uploaded the file r05.cnf for reproducing.

[msoos]

Hi,

Sorry for the late response. It was indeed a bug! I fixed it in CryptoMiniSat, here: msoos/cryptominisat@9b4ee6f

If you recompile both CMS and Bosphorus (maybe no need to recompile Bosphorus, depending on your setup), it should now work! I have tested it :)

I would like to thank you for both the perfectly reproducible problem description and your patience. Sorry, lately I've been very busy so I couldn't get to this as soon as I hoped. Nevertheless, about 1 week to fix is probably not too bad. Thanks again for the bug report, it really helped,

Mate

[Flash-LHR]

Thank you very much, it helps me a lot.

Besides, I have made a pr to set threadNum for cryptominisat in bosphorus, maybe you can consider that.

[msoos]

Ah, good point, thanks for the reminder! I merged the PR as well, and cleaned up the code a bit along the way.