Comments (3)
The same bug (not checking for exp returning Infinity) also affects e.g. cosh and sinh. I hope I'll be able to submit a more complete pull request revisiting all hyperbolic functions. I'll try this week-end.
from es5-ext.
Thanks for PR, it's merged. As a side note, if you want to implemtent tanh
on Math, it's better if you do:
equire('es5-ext/math/tanh/implement');
Also, it's not recommended to do it, in any generic packages.
from es5-ext.
I've also added tests for extreme values to sinh and cosh, and doesn't look they share same issue. If however you still think it's the case, please post failing test. Thanks!
from es5-ext.
Related Issues (20)
- v0.10.54 release breaks package installation HOT 25
- The NPM package is not a place for politics HOT 7
- Reasoning for anti-war manifest HOT 609
- On manifestations :) HOT 6
- Perhaps, some improvements to wording HOT 4
- Unfortunately the protest-ware in the manifest means your package has been marked as critical HOT 2
- Postinstall broken for pnpm 7+ HOT 6
- Postinstall not fit for Windows HOT 23
- This is not malware, but... HOT 1
- package being detected as a virus HOT 47
- npm ERR! code EINTEGRITY HOT 2
- Violation of Security-Malicious HOT 8
- Error: ELOOP: too many symbolic links encountered HOT 2
- fu'ed postinstall message HOT 2
- Clean repo from Malware scripts HOT 1
- Move "call for peace" to `README.md` to avoid unintended consequences HOT 1
- redos in es5-ext HOT 24
- Why you don't call for peace in Gaza? HOT 1
- Failed to exec postinstall script on Linux HOT 5
- Can't install on linux HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from es5-ext.