Failed to load registry bank about schwifty

[mdomke]

@cedricscheepers could you verify that something similar to

$ pyinstaller schwifty-test.py --name schwifty-test --onefile --console --add-data=C:\Users\christi\AppData\Local\Programs\Python\Python312\Lib\site-packages\schwifty:. --copy-metadata schwifty

helps?

[mdomke]

Maybe this #187 (comment) helps in your case as well?

[rokm]

The canonical solution would be --collect-data schwifty --copy-metadata schwifty and to revert #92, because the bank_registry data directory is/should be collected as sys._MEIPASS/schwifty/bank_registry and not sys._MEIPASS/bank_registry. Plus, PyInstaller supports importlib.resources.files() since v4.6 (which predates #92), so no special handling is needed. (Alternatively, the package_path for frozen codepath should be fixed into package_path = Path(__file__).parent).

[mdomke]

@rokm Thank you very much for the clarification. I'm not a pyinstaller user myself and should have paid more attention when integrating the changes in #92. The aforementioned pull-request has been reverted in release 2024.05.1. As I understand from pyinstaller/pyinstaller#8458 you would be willing to add a hook that simplifies the integration of schwifty to pystinaller? Otherwise, I could also add some instructions to schwifty's documentation.

[mdomke]

@cedricscheepers with schwifty release 2024.05.2 you should be able to do

$ pyinstaller schwifty-test.py --copy-metadata schwifty --collect-data schwifty

Possibly, a custom pyinstaller-hook will make it even easier in the future. Can you confirm that this works for you?

[rokm]

@rokm Thank you very much for the clarification. I'm not a pyinstaller user myself and should have paid more attention when integrating the changes in #92. The aforementioned pull-request has been reverted in release 2024.05.1. As I understand from pyinstaller/pyinstaller#8458 you would be willing to add a hook that simplifies the integration of schwifty to pystinaller? Otherwise, I could also add some instructions to schwifty's documentation.

Thanks for promptly taking care of the problem!

We will indeed add a hook for schwifty that will automatically perform the equivalent of --copy-metadata schwifty --collect-data schwifty - see pyinstaller/pyinstaller-hooks-contrib#742. After installing the release of pyinstaller-hooks-contrib that will include the linked PR, schwifty will work out-of-the-box with PyInstaller.