Comments (3)
commented on September 28, 2024
why use a non-iframe? google, twitter and facebook all there buttons are iframes placed by JS so that is the standard way of doing it
from github-buttons.
necolas
commented on September 28, 2024
Because this doesn't provide any functionality (unlike the social buttons of those sites). It is just a link with a count so could be rolled into your site's existing CSS and JS.
from github-buttons.
mdo
commented on September 28, 2024
I'm definitely hoping to add actual watching/forking from the buttons, but I'm super far from the skills needed to do that. Actively working on it though! Until then I'm going to leave it as an iframe and those who want to roll it up into their own and fork and/or download the repo.
from github-buttons.
Related Issues (20)
- iframes should have accessible names
- Improve Cloudflare's caching HOT 2
- Add favicons
- Add social tags HOT 1
- Add icon-only variant HOT 2
- Add queries checks
- Drop support for http? HOT 1
- add support for gists
- https://ghbtns.com/ is not accessiable HOT 2
- The star counter is not working anymore HOT 3
- Keybase proof HOT 1
- Do not use iframe for whole button HOT 3
- SPAM
- Add Web Component version
- Star count no longer showing on one of my GitHub buttons HOT 5
- Link to fork count does not point to members HOT 1
- Add support for progressive enhancement
- Reagading notifications with buttons HOT 1
- Two :star: buttons with a displayed count for different repositories on the same page display count of first repository that loads HOT 3
- Housewares, kitchen utensils and decorative tools HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-buttons.