tabs-tabs-tabs & favourite-colour about webextensions-examples

[wbamberg]

Those add-ons require Firefox 47 (currently Developer Edition) or later. You can check the minimum version required for each example by looking at the "strict_min_version" manifest key:

https://github.com/mdn/webextensions-examples/blob/master/favourite-colour/manifest.json#L5
https://github.com/mdn/webextensions-examples/blob/master/tabs-tabs-tabs/manifest.json#L5

If you could confirm that these examples work for you with Firefox 47, that would be great, and I'll close this bug.

[ind4rk]

ok, sorry. I am newby.
on 47.0a2 (2016-04-25) linux ubuntu
tabs-tabs-tabs works but favourite-colour dont work.
"# Favourite Colour

Shows and stores your favourite colour, in storage.local
in the about:addons page for the add-on."
in about:addons page there are nothing to do.

[wbamberg]

Don't be sorry :). Minimum version requirements should be more obvious than they are. Firefox should refuse to install add-ons that don't meet the minimum version, and newer versions of Firefox do this, but Firefox 45 doesn't have that fix.

in about:addons page there are nothing to do.

To be clear: in about:addons you should see a button labelled "Preferences" next to the add-on, like: https://i.imgur.com/yRJQ5Vj.png. If you click the button, you should see the options UI: https://i.imgur.com/HALMbzY.png.

Are you seeing any of that?

[ind4rk]

Firefox version http://i.imgur.com/5GGsQkK.png
about:addons page for the add-on http://i.imgur.com/QKPUzxy.png
about:addons http://i.imgur.com/remjDjW.png
I test on windows 7 and same result :(

[wbamberg]

Sorry, could you try with Firefox 48 (current Nightly)? I think the strict_min_version might be wrong for this one...

[ind4rk]

on Firefox Nightly x64 version 48.0a1 (2016-04-25) works. OS linux ubuntu. :)

[wbamberg]

I've just pushed b75b182, which should fix strict_min_version for this example.

Thanks for finding this! I'll close this for now, but let me know if you think anything else is needed.

[ind4rk]

Is offtopic but in webextensions-examples-> README.md
"Before you try out these extensions, read about prerequisites."
if you click on the link.
"All you need is Firefox 45 or higher. See Your first WebExtension to get started."
is my fault for not check the manifest.json but this line confus me.
sorry for my english :P

[wbamberg]

You're right, that's super-confusing. I just updated the README:

https://github.com/mdn/webextensions-examples/blob/master/README.md

Is this better, do you think?