Comments (4)
Hm, yes, I just added the EntityInterface typehint to the method in fe3ebb8, making the test pass. FileEntity implements that interface but not directly.
FileEntity ⇾ File ⇾ FileInterface ⇾ ContentEntityInterface ⇾ FieldableEntityInterface ⇾ EntityInterface
from file_entity.
Then you should get an exception about FileEntity not implementing the EntityInterface in the tests.
from file_entity.
No errors about that on the travis-ci build, nevermind then:
https://travis-ci.org/md-systems/file_entity/jobs/67208511
from file_entity.
The fix looks fine. FileEntity can not not implement that interface, it extends from a class that does. It's more likely that the parent method there was changed and that broke it. That also means that the related core patches for bringing this into core need to be updated if they haven't been already.
from file_entity.
Related Issues (13)
- ReST GET expected result at file/{fid} HOT 4
- Permissions required for ReSTful GET on file/{fid} are too permissive
- File Entity fields are not available in REST export HOT 3
- Test fails HOT 1
- Fix batch deletion of files. HOT 3
- Merge in drupal-media/file_entity? HOT 1
- Property "display" is unknown when normalizing ImageItem fields
- Add tests for normalize/denormalize image fields HOT 1
- Why are route paths unquoted in File Entity but not in say, the Node module?
- File entity doesn't disable the core files list view which causes two files tabs to display. HOT 4
- Fatal error when replacing a file HOT 3
- Trying to install on beta3 results in fatal error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from file_entity.