Coder Social home page Coder Social logo

Comments (4)

arildm avatar arildm commented on May 18, 2024

Hm, yes, I just added the EntityInterface typehint to the method in fe3ebb8, making the test pass. FileEntity implements that interface but not directly.
FileEntity ⇾ File ⇾ FileInterface ⇾ ContentEntityInterface ⇾ FieldableEntityInterface ⇾ EntityInterface

from file_entity.

LKS90 avatar LKS90 commented on May 18, 2024

Then you should get an exception about FileEntity not implementing the EntityInterface in the tests.

from file_entity.

LKS90 avatar LKS90 commented on May 18, 2024

No errors about that on the travis-ci build, nevermind then:

https://travis-ci.org/md-systems/file_entity/jobs/67208511

from file_entity.

Berdir avatar Berdir commented on May 18, 2024

The fix looks fine. FileEntity can not not implement that interface, it extends from a class that does. It's more likely that the parent method there was changed and that broke it. That also means that the related core patches for bringing this into core need to be updated if they haven't been already.

from file_entity.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.