Undefined method: `setTimeout(...).unref` about async-cache-dedupe

[mcollina]

Check out how readable-stream run the browser tests.

[mcollina]

These methods are defined in Node.js, so there is no point in testing if they exists, because they always will.

Are you running this in the browser? Or maybe one of those frameworks is changing the globals.

[mateonunez]

These methods are defined in Node.js, so there is no point in testing if they exists, because they always will.

You're right, that method is always defined in Node.js, but unfortunately not in browsers.

I create a local build of the plugin with that change and made some tests with browsers and frameworks, it seems to work fine. It hits/miss/dedupe the cached keys, etc.

[mcollina]

I'm ok for a contribution that adds official support browsers and possibly other runtimes. This should be documented and tests.

Certain features shouldn't be available, eg Redis.

[mateonunez]

Certain features shouldn't be available, eg Redis.

Yes, there are some limitations by supporhting browsers, it should be documented.

How did you plan to proceed with testing? It should use some package to mock the browser environment?

I think I can work on browser compatibility, then I would test other runtimes.

WDYT?