Comments (6)
Yeah I don't think I can make it in time haha. I am still getting familiar to the codebase, plus I don't have much free time lately. But who knows, we'll see how it goes :)
from lorien.
Hello, glad you find it useful! :)
I am familiar with Milton and how it handles saving files and to be honest i don't really like it. I want to be in control when to save a file and where. That being said, i do want a feature that opens up all files of the previous session. Like if you have 3 files open and then close Lorien. Then the next time you open it these 3 files should load automatically.
So basically: yes to restoring sessions/previously opened files, but no to mandatory auto-saving without asking the user where the files should be saved to. This could be implemented via a simple list of strings (saved to user://session.cfg
alongside user://settings.cfg
) pointing to the absolute paths of the files. If you close Lorien all open files (that have already been saved) will be referenced in there and when you open Lorien it first reads this files and the loads all .lorien
files it points to.
"Normal" auto-save can still be implemented at a later stage (should be possibile to enable/disable in settings though).
from lorien.
Thanks for the feedback! To clarify, this is how I would envision the flow:
- The user has open files they have not saved (either at all or made changes to existing files), and they close the window.
- Lorien saves the files that have a path (files that exist on disk already) with the newer version.
- Lorien saves the dirty files that haven't been saved before to either the default project folder (most likely within a subfolder to prevent confusion) or to
user://
(again, to a subfolder) - On reopening Lorien, all of these open back, and the files that haven't been saved before get marked as dirty to let the user know they haven't saved them (depending on the implementation, this may break backwards compatibility, eg. if the dirty bit is set in the project file)
If I understand you correctly, you are against the third point and the second half of the fourth?
from lorien.
Yes exactly. Basically everything would stay the same except open files would be loaded automatically if Lorien is reopened. So i guess i'm also against point 2 for now as that is a different feature (see below)
Once that is implemented we can add auto-save (disabled by default) for files with a path (already on disk) in a seperate PR:
- Based on a timed interval (like every 5 min)
- When the user exits Lorien
That would cover most of your features except the saving of not explicitly saved files to a project folder or somthing...i don't really like that.
from lorien.
Also if you want to work on this: i plan to release a new version this weekend which would include the new color palette feature i'm currently working on. Would be cool if this could make it in as well :)
But don't worry if you need more time, there is always a next version.
from lorien.
No worries. Let me know if you have more questions!
from lorien.
Related Issues (20)
- Circle and rectangle tool lags the app
- More tools: hand to move around the canvas HOT 1
- All the UI triggers full screen after entering fullscreen for the first time
- Snap to grid
- Single mouse click to paint a dot HOT 1
- Zoom buttons for Fit All, Home, Center HOT 1
- Adding key binds for all the tools HOT 2
- Selection between Super Eraser mode and Normal Eraser mode
- being able to hold space and move around the canvas HOT 2
- [Feature] Able to select all or certain elements hotkey
- [Feature] Straight lines for brush tool
- Highlighter tool
- Lorien Not Launching After Snap Installation on Fedora 37 HOT 1
- Program crashes when switching to eraser while drawing HOT 3
- Keyboard shortcuts for color selection
- Line thickness inconsistencies in Windows HOT 2
- Cursor not showing in "Save changes?" dialog when closing the app
- Add another extra type of eraser
- Higher than expected CPU usage when drawing on the canvas HOT 1
- UI Scale effects grid size when window size changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lorien.