Comments (11)
Would you prefer I break this into two issue?
from pass4win.
No it's ok like this.
from pass4win.
Instead of a button (sync or whatever) would a check every x minutes work too?
from pass4win.
Problem is I routinely run without connectivity to my workstation. It may be a day or a few days between sync ups. I do not add or modify my passwords daily. More like weekly or even biweekly. I suspect many are in a similar position. The command line version requires you to run 'pass git push' or the like.
In terms of battery, network, etc. any kind of "is git alive" check would just be wasteful for a common use case. From a programming perspective, a simple way to toggle "online" or not is the baseline required functionality. Connecting that to a timer or a button afterwards is pretty straightforward.
from pass4win.
I'm looking at the source but it seems that when you first config it and set the remote checkbox it checks if the remote is online and if not sets it to offline with an error message.
Is that wrong or did it work different for you?
from pass4win.
I think the code itself is working as you intended. I am arguing that the UX is not up to par.
On first config I know I do have a remote so I click the box. I enter the info. However, I am at home, not work. So the git repo is not available. I cannot proceed without disabling the "use remote" check box. I should be able to configure it and have the application detect I am "offline" and allow me to continue. Potentially with an incorrect config if there is a typo. later when I know I can go online the application can let me know if something breaks.
from pass4win.
Ah ok, I always want to check all input and when not possible input it later. Tbh I can see advantages and disadvantages to both approaches.
Thinking about it this is what I'll do for both initial config and normal operation:
- check if stuff is semantically correct
- check if alive
- if !alive fail silently and put the offline txt. Do not change config info (checkbox)
- if someone presses the sync button and something fails tell them what.
Ok? Any ammends?
from pass4win.
Sounds right.
from pass4win.
fixed in ebe8cd7
from pass4win.
Released, let me know if it works :-)
from pass4win.
Looks good.
from pass4win.
Related Issues (20)
- Add support for customizing how long the password lives in the clipboard HOT 4
- Git sync fails to git:// repo HOT 7
- Install does not work on Windows 7 x64 HOT 3
- Functionality to opt out of git(ex in the path select screen) HOT 5
- Unhandled exception HOT 4
- Search not working - always returns "No Value" HOT 11
- Newbie Question: How to setup HOT 1
- Main Window Input Blocked While Config Open does not Block Config Button HOT 2
- .exe identified as trojan HOT 5
- cant install directly over, lose everything HOT 1
- Sharing between linux and windows HOT 3
- Ability to select a leaf folder without selecting a password entry HOT 3
- Add option to disable symbols in password HOT 1
- Show password as qr code
- unhandled exception on startup HOT 3
- Is the project maintained elsewhere? HOT 2
- passwords doesn't get cleared after specified time
- german translation strings are to long.
- Program is reading out registry keys from other programs
- Consider archving this project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pass4win.