Cached columns bug (CRITICAL) about acts-as-taggable-on

Fixed in 9c80976

[dsmalko]

Problem is not solved.

Code:

Post.create! :tag_list = "one, two"

post = Post.first
post.save!

post = Post.first
post.tag_list # => []
post.cached_tag_list # => "
post.tags # => [#<Tag id: 5, name: "one">, #<Tag id: 6, name: "thow">]

[ironoxid]

I confirm. Problem is not solved. Critical.

[ironoxid]

Hi! I confirm. Problem isn't solved and remains critical.
About what dsmalko said:

1. post.tag_list is empty after save! because it (just) load tags from cached_tag_list if caching is enabled
2. cached_tag_list is empty because save_cached_tag_list sets it to an empty string on save! because tag_list_cache_on returns nothing (@my_custom_tag_list is not initialized - look at tag_list_cache_on)

This bug is critical. Not only cache is not reliable but also we loose taggings if fields about our tags are filled with my_custom_tag_list method (it's empty due to cached and so... bye bye baby on form submit - argh!).

Today i spend one hour to figure out what was happening.
This is my patch. It seems to work well

/lib/acts_as_taggable_on/acts_as_taggable_on.rb @387
remove:
send(:"cached_#{tag_type.singularize}list=", tag_list_cache_on(tag_type.singularize).to_a.flatten.compact.join(', '))
use:
list = tag_list_cache_on(tag_type.singularize)
send(:"cached#{tag_type.singularize}_list=", list.to_a.flatten.compact.join(', ')) if list.any?

My patch takes hash from tag_list_cache_on and check if it's empty. Only if it's not empty I update cache column. If tag_list_cache_on returns {} I assume that @my_custom_tag_list is not initialized, so there is no change about tags and no need to update cache column (this avoid to save empty cache columns when @my_custom_tag_list is not initialized).
Anyway I can't be completely sure about what I assume at the moment, but I think that hash cannot be empty, just because it's a pair of owner => tags and if there is no owner for a tag (or not tags at all) we always have at least a nil key, for example {nil => []}. Isn't it?

I'm testing. For the moment my patch works well.
I'm sorry for my bad english! :)

[ironoxid]

Also If you don't want to patch your plugin or wait a fix, just call your_custom_tag_list method before save so instance variable will be initialized

[ironoxid]

Testing and one week on production. Patch is ok.

I've fixed this problem in version 2.0.0 which was just released

[ironoxid]

ty!