Comments (4)
The current setting is
allow_browser versions: :modern
I wonder if this is something you want to keep like that?
The main limitation is for Safari which is not evergreen and the current requirement is 17.2 with :modern
, source
Here are the real world usage for Baseamp
https://x.com/dhh/status/1783888747769250255
17.2 Safari brings the :has css selector but I haven't seen any in the code base (very quick scan)
from maybe.
@adrienpoly I don't have a super strong opinion on this one. As long as we're not spending significant dev hours trying to research and support differences across browsers and browser versions, I'd be open to making this less restrictive.
What setting would you recommend?
from maybe.
@zachgoll I don't have a strong opinion either. I wouldn't be worried about Chome/Firefox version as they are evergreen but more about Safari. Looking at Basecamp data it feels like only 56% of their Safari users would be able to access the site with the current configuration.
I am unsure what is the typical user of your solution when it is live but as it is personal finances I believe lots of users won't be as techy as we (developers) are and could easily run an older version on their mac at home.
Also it depends when the release date is scheduled for. As explained in the PR this is a proposed setting for Rails 8 that is not released right now. By the time it is released maybe the usage stats will be much different.
On my side I would probably put a Safari >= 16.0 as I don't feel you are doing edgy things with CSS
from maybe.
@adrienpoly yeah I think Safari >= 16 would be reasonable, and then keep the "modern" version requirements for the remaining browsers.
from maybe.
Related Issues (20)
- Make account "History" and "Transactions" sections more clear HOT 2
- Bug: docker-compose up -d fails during first install HOT 3
- Bug: pie chart on dashboard does not support multi-currency formatting HOT 4
- Bug: after editing an account history value, it requires 2 clicks to close the menu HOT 3
- Bug: Invalid email or password. HOT 3
- Internal account links and redirect behaviors are not optimal
- Allow user to "sync" their account as many times as they want
- Allow users to mark transactions as "payments" or "transfers", which are excluded from income and expense calculations
- Allow users to assign manual accounts to an "Institution" and edit account details after creation
- Transaction pagination should be in a "fixed" container for easier UX interactions
- Bug: During transaction import, when user returns back to "mappings" step, all columns have reset in the forms
- Improvement: Make the "start date" on an account optional for manual accounts
- Improvement: Allow user to configure date and amount format during transaction imports
- Bug: Invalid self hosting settings show on Docker hosted apps
- Unable to add new entry for any types of accounts HOT 1
- Test
- Bug:
- Bug: HOT 1
- Safari 16.6 (18615.3.12.11.2) not supported.
- Add Investment Transaction Type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maybe.