Coder Social home page Coder Social logo

Comments (13)

sy425191 avatar sy425191 commented on May 22, 2024 2

I would like to work on this

from maybe.

Shpigford avatar Shpigford commented on May 22, 2024 2

@tmyracle Been digging a bunch and can't find anything. :( Will keep looking, but not looking great.

from maybe.

Shpigford avatar Shpigford commented on May 22, 2024 1

Whoever would like to work on, go for it. Generally speaking, if you start working on, create a draft PR to show your progress.

That can help reduce multiple people working on the same issue.

from maybe.

eneskaya avatar eneskaya commented on May 22, 2024 1

I'm still on it, please see #117 . Having a hard time testing with Postmark, though. Can't send an email to my private address 😅 Probably need to set up an own domain so I can test this.

What's missing now is:

  • UI for actually resetting the email + hooking it up with the BE to do the reset
Bildschirmfoto 2024-01-20 um 16 41 33 Bildschirmfoto 2024-01-20 um 16 41 46

from maybe.

tmyracle avatar tmyracle commented on May 22, 2024 1

@Shpigford do you happen to have screenshots/examples?

rebuild

from maybe.

eneskaya avatar eneskaya commented on May 22, 2024 1

@eneskaya depends on what we decide to use for templating moving forward, my vote would be for React Email mentioned above since you can write emails as react components and it takes care of cross-client support and generating the html for you. Might have to put this on pause until we get a templating solution in place.

I was talking about where to put them in the monorepo 😁 But let me create a new issue for the email templates, and we can discuss there

from maybe.

Neumand avatar Neumand commented on May 22, 2024

Same, I'd love to help on this

from maybe.

tmyracle avatar tmyracle commented on May 22, 2024

@eneskaya are the email templates managed in Postmark itself? I can't seem to find any in the repo and looks like its just referencing them by id. Might make sense to move to something like React Email so that the templates are in source control and you can style them with React and Tailwind. They also play nice with Postmark, Resend, Nodemailer, SendGrid, Plunk, and AWS SES

from maybe.

Shpigford avatar Shpigford commented on May 22, 2024

There were indeed templates managed in Postmark, but we closed that account so lost access to them. :(

from maybe.

eneskaya avatar eneskaya commented on May 22, 2024

@eneskaya are the email templates managed in Postmark itself? I can't seem to find any in the repo and looks like its just referencing them by id. Might make sense to move to something like React Email so that the templates are in source control and you can style them with React and Tailwind. They also play nice with Postmark, Resend, Nodemailer, SendGrid, Plunk, and AWS SES

That is a very good point. Right now I'm setting a raw text body, but wanted to bring up whether having the templates in the code base wouldn't make more sense. React Email would be a perfect candidate here, I agree! I will add it.

The issue still remains though with local testing, but we could wait with that until we have SMTP support, which would make testing easier.

from maybe.

eneskaya avatar eneskaya commented on May 22, 2024

@tmyracle Where exactly would you put the email templates?

from maybe.

tmyracle avatar tmyracle commented on May 22, 2024

@eneskaya depends on what we decide to use for templating moving forward, my vote would be for React Email mentioned above since you can write emails as react components and it takes care of cross-client support and generating the html for you. Might have to put this on pause until we get a templating solution in place.

from maybe.

tmyracle avatar tmyracle commented on May 22, 2024

Not relevant anymore

from maybe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.