Conversion errors with 0.1.143 about libforge

[maxton]

Thanks for the report, the more failures I can check, the better conversions will get. So I appreciate the time you've taken to test all of these.

The ones which fail to convert entirely are the easiest to fix, so I'll probably work on fixing those first. The ones which crash RB4 are trickier, but hopefully they will get fixed with other general improvements made to the conversion process. The 4 that are mislabeled as the wrong artist are the most surprising, as the artist data should be coming directly from the DTA, same as RB3!

I'll look through these and create more specific issues if I can track down what's causing the failures.

[maxton]

Ok, I made a list of the unique errors and checked off the ones I fixed so far:

Conversion errors

• Seek past end of texture stream (Texture conversion) #17
• Index was outside the bounds of the array (Texture conversion) #18
• Index was outside the bounds of the array (Lipsync) #20
• Index and length must refer to a location within the string (ID generation) #21
• Unhandled midi note 115 in drum track (MIDI conversion) #28
• Texture was not 512x512 or 256x256 (Texture conversion) #29
• Length of the data to encrypt was invalid (PKG.PkgWriter.WriteBody) maxton/LibOrbisPkg#29
• Offset and length were out of bounds for the array... (PKG.KeysEntry) maxton/LibOrbisPkg#30

Loading errors

• Shortname collisions (mislabeling) #26
• Case sensitivity problems (crashes) #27

[maxton]

@Elrondolio I think these should all convert now (some may not have album artwork after conversion, yet). The one error I couldn't reproduce is the one you got with Pearl Jam - Yellow Ledbetter, so maybe that was a one-off issue with your PC?

[Elrondolio]

Wow, @maxton that was very quick and very thourough work. Thank you! I haven't played through all of them of course but they all convert and, indeed, load properly now. That includes Yellow Ledbetter so it must have been my system on that one.

Thanks again for enabling such a huge part of my family's PS4 enjoyment. I'll keep downloading and testing new customs and let you know if I run across any other issues. Happy new year!