Comments (4)
Probably not, because I feel like the SVGs could be huge compared to the actual image file?
after some thought, I think I am okay with supporting hosting images, but it would require a bit of work. I guess we could embed the image in sqlite, but its probably better to store it as-is and serve it from the folder location on disk. @adyanth any thoughts on this? I appreciate your input
from drift.
No, there’s no real technical reason except showing them in the preview rendered. It probably makes most sense to do what GH does and upload images into Markdown and just provide a link, but file hosting (rather than just text) is out of scope for this project imo.
from drift.
Would converting the image to SVG and embedding it in the file be within scope?
from drift.
The size would be large when using SVG.
I haven't seen any pros/cons on storing images in the DB vs the filesystem to comment on which would be better.
Storing images in a filesystem path (configurable) is good enough which may (in the future if needed) allow something like nginx serve the bulk static content if necessary. Even cache the content if needed.
I would recommend having a separate endpoint for these content. Also, similar to how GitHub does it, would be better to generate a random filename (and strip metadata) for the images before saving it.
from drift.
Related Issues (20)
- [Discussion] Implementing post updating and history HOT 1
- Support light and dark mode specific image URLs
- install error: https://github.com/mapbox/node-sqlite3 tag not found HOT 3
- Display after saving and more syntax highlighting HOT 2
- Provides documentation about the APIs HOT 1
- Failed to update prerender files for /index
- page content overlaps mobile menu HOT 2
- [Feature Request] Single Docker image HOT 3
- Support more auth providers HOT 4
- Re-implement toasts
- Three Build issues in docker HOT 1
- Highlight a specified few lines of code
- Websites using Drift HOT 1
- Truncate long post names on the list view HOT 1
- [Discussion] storing the HTML and the content for posts in the database HOT 1
- Missing Gist features
- [Proposal] (Server) Decouble DB from routes (from domain logic) HOT 1
- Run linter on pre-commit hook HOT 5
- Dependency Dashboard
- Warn user when images don't have an alt tag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drift.