Coder Social home page Coder Social logo

Comments (30)

mateusz1913 avatar mateusz1913 commented on May 28, 2024 4

I also encountered that issue, however that code seems to be related only to maven publishing.
Workaround with patch-package:

task androidJavadoc(type: Javadoc) {
        source = android.sourceSets.main.java.srcDirs
        classpath += files(android.bootClasspath)
-        project.getConfigurations().implementation.setCanBeResolved(true)
-        classpath += files(project.getConfigurations().getByName('implementation').asList())
+        // https://github.com/maxkomarychev/react-native-ultimate-config/issues/107
+        // This is only for publishing to maven, so commenting it out does not affect app
+        // project.getConfigurations().implementation.setCanBeResolved(true)
+        // classpath += files(project.getConfigurations().getByName('implementation').asList())
        include '**/*.java'

}

from react-native-ultimate-config.

maxkomarychev avatar maxkomarychev commented on May 28, 2024 1

hey @vagnerlandio would you like opening a PR here and/or getting more permissions in the project to avoid fragmentation?

p.s. you are correct, I was not able to allocate enough time to keep up with all incoming issues and challenges and I'm willing to add more people to work on this project!

from react-native-ultimate-config.

maxkomarychev avatar maxkomarychev commented on May 28, 2024 1

There was a massive refactoring made to the library and this problem could have been fixed in a new version 4.1.0-alpha.0 (#128)

Please give it a try!! Thank you!

from react-native-ultimate-config.

maxkomarychev avatar maxkomarychev commented on May 28, 2024 1

@elliotdickison @vagnerlandio I value your contribution and willingness to support this project! I am figuring out logistics related to permissions & workflows when adding more people to the repository.

Stay tuned!

from react-native-ultimate-config.

anrodrigues0 avatar anrodrigues0 commented on May 28, 2024

i think i have the same problem, when I try to compile with version 69.1 of react native it gives me this error. :(

`* What went wrong:
A problem occurred configuring project ':react-native-ultimate-config'.

Could not resolve all files for configuration ':react-native-ultimate-config:implementation'.
Could not resolve com.facebook.react:react-native:+.
Required by:
project :react-native-ultimate-config
> Cannot choose between the following variants of com.facebook.react:react-native:0.69.1:
- debugVariantDefaultRuntimePublication
- releaseVariantDefaultRuntimePublication
All of them match the consumer attributes:
- Variant 'debugVariantDefaultRuntimePublication' capability com.facebook.react:react-native:0.69.1:
- Unmatched attributes:
- Provides com.android.build.api.attributes.BuildTypeAttr 'debug' but the consumer didn't ask for it
- Provides org.gradle.category 'library' but the consumer didn't ask for it
- Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
- Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
- Provides org.gradle.status 'release' but the consumer didn't ask for it
- Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
- Variant 'releaseVariantDefaultRuntimePublication' capability com.facebook.react:react-native:0.69.1:
- Unmatched attributes:
- Provides com.android.build.api.attributes.BuildTypeAttr 'release' but the consumer didn't ask for it
- Provides org.gradle.category 'library' but the consumer didn't ask for it
- Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
- Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
- Provides org.gradle.status 'release' but the consumer didn't ask for it
- Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it`

from react-native-ultimate-config.

vinipachecov avatar vinipachecov commented on May 28, 2024

I also encountered that issue, however that code seems to be related only to maven publishing. Workaround with patch-package:

task androidJavadoc(type: Javadoc) {
        source = android.sourceSets.main.java.srcDirs
        classpath += files(android.bootClasspath)
-        project.getConfigurations().implementation.setCanBeResolved(true)
-        classpath += files(project.getConfigurations().getByName('implementation').asList())
+        // https://github.com/maxkomarychev/react-native-ultimate-config/issues/107
+        // This is only for publishing to maven, so commenting it out does not affect app
+        // project.getConfigurations().implementation.setCanBeResolved(true)
+        // classpath += files(project.getConfigurations().getByName('implementation').asList())
        include '**/*.java'

}

This works for me!

from react-native-ultimate-config.

DartVadius avatar DartVadius commented on May 28, 2024

react-native 0.70.0 same issue

from react-native-ultimate-config.

Sabaturdzeladze avatar Sabaturdzeladze commented on May 28, 2024

The library does not work for the latest RN versions (> 69.0) on android (iOS seems fine)

from react-native-ultimate-config.

Tohid1999 avatar Tohid1999 commented on May 28, 2024

Same with react-native 0.70.4

from react-native-ultimate-config.

elliotdickison avatar elliotdickison commented on May 28, 2024

@vagnerlandio Thanks! Unblocked me when migrating to react-native 0.70.5

from react-native-ultimate-config.

marcshilling avatar marcshilling commented on May 28, 2024

@mateusz1913's solution above works for me and seems much simpler than @vagnerlandio's. What's the difference between these approaches and is either better or worse?

from react-native-ultimate-config.

mateusz1913 avatar mateusz1913 commented on May 28, 2024

@marcshilling I provided only a workaround which disables some code regarding maven publishing. I didn't check whole @vagnerlandio solution, but it seems to be more complete solution. I don't have an idea which is better, as I didn't use that library for a longer time

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

@marcshilling I consider @mateusz1913 solution to be better, as it has fewer modifications and solves the problem.

Thinking about it, I will delete my solution, because it has many modifications, new bugs may appear.

from react-native-ultimate-config.

HenryLee2703 avatar HenryLee2703 commented on May 28, 2024

Have any solution without editing on node-modules like this?
I have the same issue like this

from react-native-ultimate-config.

HenryLee2703 avatar HenryLee2703 commented on May 28, 2024

Have any solution without editing on node-modules like this? I have the same issue like this

Hi, anyone here?

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

Have any solution without editing on node-modules like this? I have the same issue like this

Hi, anyone here?

You can fork the project, edit the necessary file, commit and add the package to the project from the fork using yarn add https://github.com/HenryLee2703/react-native-ultimate-config

from react-native-ultimate-config.

HenryLee2703 avatar HenryLee2703 commented on May 28, 2024

Have any solution without editing on node-modules like this? I have the same issue like this

Hi, anyone here?

You can fork the project, edit the necessary file, commit and add the package to the project from the fork using yarn add https://github.com/HenryLee2703/react-native-ultimate-config

maybe it's a not good solution. I'm working in a project with a lot of people, they can depend on me and otherwise.
Maybe the author of this library should have some adjusting on this library, he should update the library follow up by the latest version of react native. it's out of date

from react-native-ultimate-config.

elliotdickison avatar elliotdickison commented on May 28, 2024

@maxkomarychev Do you have thoughts on the patch from @mateusz1913? Would there be a way to merge a variation of that without breaking the Maven publishing process?

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

By the amount of unanswered messages in this and other opened issues, I presume that the author has paused development and maintenance of the package.

I have dozens of published applications that depend on this package so I created a fork of the project, renamed it and published it on npm as react-native-awesome-config (v4.1.1)

This new version has the following changes:

  • package updated with support for version 0.71.0 of react-native.
  • example project updated to version 0.71.0 of react-native.
  • example-web project updated for version 18.2.0 of reactjs.
  • Fixes for build on ios
  • Fixes for build on android.
  • All tests pass 100% coverage
  • Dependencies updated to the latest stable versions.
  • Other small changes, nothing significant.

Obs: The project was renamed, but I kept the "rnuc" command for better compatibility.

from react-native-ultimate-config.

HenryLee2703 avatar HenryLee2703 commented on May 28, 2024

By the amount of unanswered messages in this and other opened issues, I presume that the author has paused development and maintenance of the package.

I have dozens of published applications that depend on this package so I created a fork of the project, renamed it and published it on npm as react-native-awesome-config (v4.1.1)

This new version has the following changes:

  • package updated with support for version 0.71.0 of react-native.
  • example project updated to version 0.71.0 of react-native.
  • example-web project updated for version 18.2.0 of reactjs.
  • Fixes for build on ios
  • Fixes for build on android.
  • All tests pass 100% coverage
  • Dependencies updated to the latest stable versions.
  • Other small changes, nothing significant.

Obs: The project was renamed, but I kept the "rnuc" command for better compatibility.

Hi @vagnerlandio , how about react native version 0.70.6? Does the react-native-awesome-config support this version. I've init a project with many dependencies of version 0.70.6 .
Thank you

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

hey @vagnerlandio would you like opening a PR here and/or getting more permissions in the project to avoid fragmentation?

p.s. you are correct, I was not able to allocate enough time to keep up with all incoming issues and challenges and I'm willing to add more people to work on this for project!

would be great. And then I delete the version I pushed to npm

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

By the amount of unanswered messages in this and other opened issues, I presume that the author has paused development and maintenance of the package.
I have dozens of published applications that depend on this package so I created a fork of the project, renamed it and published it on npm as react-native-awesome-config (v4.1.1)
This new version has the following changes:

  • package updated with support for version 0.71.0 of react-native.
  • example project updated to version 0.71.0 of react-native.
  • example-web project updated for version 18.2.0 of reactjs.
  • Fixes for build on ios
  • Fixes for build on android.
  • All tests pass 100% coverage
  • Dependencies updated to the latest stable versions.
  • Other small changes, nothing significant.

Obs: The project was renamed, but I kept the "rnuc" command for better compatibility.

Hi @vagnerlandio , how about react native version 0.70.6? Does the react-native-awesome-config support this version. I've init a project with many dependencies of version 0.70.6 . Thank you

I tested only in versions 0.70.0, 0.70.1, 0.7.4 and 0.71.0.
As it worked in the latest version so I believe it will also work in this version 0.70.6

from react-native-ultimate-config.

maxkomarychev avatar maxkomarychev commented on May 28, 2024

@vagnerlandio could you please open a pr from the top of your master, I will allocate some time to review changes this week and figure out logistics related to collaboration in this repository and publishing new versions. thanks!

from react-native-ultimate-config.

HenryLee2703 avatar HenryLee2703 commented on May 28, 2024

@vagnerlandio could you please open a pr from the top of your master, I will allocate some time to review changes this week and figure out logistics related to collaboration in this repository and publishing new versions. thanks!

Thanks for your paying attention about our issues, u can review above answers to resolve the issues, hope u push a new version resolved issue asap

from react-native-ultimate-config.

maxkomarychev avatar maxkomarychev commented on May 28, 2024

@HenryLee2703 is that the fix that is confirmed to work in this particular case #107 (comment) ?

from react-native-ultimate-config.

HenryLee2703 avatar HenryLee2703 commented on May 28, 2024

@HenryLee2703 is that the fix that is confirmed to work in this particular case #107 (comment) ?

What fixing do you mean?

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

@vagnerlandio could you please open a pr from the top of your master, I will allocate some time to review changes this week and figure out logistics related to collaboration in this repository and publishing new versions. thanks!

OK, by the end of the week I will do that, I will also do a review on the changes I made, although it works in react-native version 0.71.0 I found a problem in an app that uses an older version. I'll analyze further and then fix it if necessary. (maybe the problem is in my app and not in the package)

from react-native-ultimate-config.

elliotdickison avatar elliotdickison commented on May 28, 2024

p.s. you are correct, I was not able to allocate enough time to keep up with all incoming issues and challenges and I'm willing to add more people to work on this project!

@maxkomarychev I'd be happy to help maintain - I can at least support the web functionality that I added awhile back. You've created by far the best RN config package out there and I'd love to see it live on.

from react-native-ultimate-config.

vagnerlandio avatar vagnerlandio commented on May 28, 2024

@maxkomarychev I've opened the pull request #128 . Please review and let me know if there are any changes that need to be made before it can be merged.

@elliotdickison can you test the maven publishing process in this pull request? In my tests, gradle test, gradle build and gradle publish worked perfectly.

@HenryLee2703 You could also test if the #128 solves your related issue?

Thanks!

from react-native-ultimate-config.

maxkomarychev avatar maxkomarychev commented on May 28, 2024

Closing this for now.

from react-native-ultimate-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.