Coder Social home page Coder Social logo

Comments (18)

barryvdh avatar barryvdh commented on August 15, 2024

Sounds cool :) Will try and test this tonight.

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

I pushed some bug fix and refactoring. Everything should work now.
I renamed ServerHandler\Server to ServerHandler\FrontControler

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

Okay will try in a bit. I hope you aren't going to release this also as 1.9.x, are you? Because it will probably break my integration ;)

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

haha no worries. will do a 2.0 with that. I'm also working on other things which will be pushed with the new version. what do you think of a "console" widget? ;)

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

Would be nice :) Do you want to provide a simple console to start a new request, or hook into the current request (which would be more difficult)
Laravel has a command line tool to start Boris repl, with the framework fully loaded, would be cool if we could do that From the debugbar.
I did actually have this feature requested: barryvdh/laravel-debugbar#66
This might be interesting to follow some of the problems/examples: filp/whoops#42 (and the linked issue from symfony etc)

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

btw I re-created the dev branch. it will become the 2.0

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

Ok.
Was there any reason why you removed the resources vendors from gitignore? Now the resources are around 10MB..

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

it was a weird situation. the folder was already versionned (if not you would have had to run "bower install" everywhere) but was ignored after. this means new versions of the scripts in vendor where ignored. The new size is due to an update to jquery and font-awesome which added all the source files.

I'm not in favor of ignoring this folder and having to run bower install. not enough people know/have installed bower. I'm open to other solutions however (we could only add the files we need)

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

How it was before, was that the folder was ignored, but the files that were need, were force pushed, right? So people didn't need Bower and only the files that were used, were in the Resources folder.
Don't know if that makes updating harder, but it was a lot smaller.
(And size doesn't really matter that much, but it seems a bit much)

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

I'll do something to fix that

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

Your serverHandler was pretty easy to change btw :) barryvdh/laravel-debugbar@35d1769
Seems to work still fine :)
Want anything specific tested, or more a general question what would be possible?

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

great to hear that! Looking at your code I wonder how the request data are being passed as the first argument of handle() is null?

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

First lines of handle():

if ($request === null) {
    $request = $_REQUEST;
}

I was going to make it more Laravel/Symfony like with the request object etc, but figured this works just fine :)

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

haha oups forgot that! great then

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

Okay starting to pick this up again. I like the way this was going (with clearing the cache etc as examples), but it's not really easy to merge the dev-branch now I think.

Should I just recreate a 2.0 branch and redo the changes manually? Or what do you think?

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

you think rebasing would be too difficult? I think it may be worth a try.
I have nothing against a 2.0 branch anyway

from php-debugbar.

barryvdh avatar barryvdh commented on August 15, 2024

Not sure, it's a lot behind now. But will give it a try if I get the chance soon.

from php-debugbar.

maximebf avatar maximebf commented on August 15, 2024

I rebased dev and pushed it under the branch dev_rebased
Haven't got time to test it though

from php-debugbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.