Comments (11)
copying the fonts to app/assets/fonts seems to solve the issue... but... why? 😕 is the gem missing these fonts? sorry for my lack of understanding on how this works.
from bootswatch-rails.
@pablocrivella We don't provide those fonts. bootstrap-sass is the one that have them:
https://github.com/twbs/bootstrap-sass/blob/115fa1e5338489c312bb7131284d9badd4c18cec/lib/bootstrap-sass/engine.rb#L5
I'll investigate if the version you're using of bootstrap-sass (3.1.1) is having this issue.
from bootswatch-rails.
If it is of any help, i'm using Rails 4.1 and sass-rails 4.0.3.
from bootswatch-rails.
The variables.css.scss files of the swatches define:
$icon-font-path: "../fonts/" !default;
comment that line out of the file and the problem is fixed
from bootswatch-rails.
@esbanarango so changing this line https://github.com/thomaspark/bootswatch/blob/gh-pages/flatly/variables.less#L75
(and for every other bootswatch theme) to use sass-rails font helpers could solve it.
from bootswatch-rails.
I would change it here: https://github.com/maxim/bootswatch-rails/blob/master/vendor/assets/stylesheets/bootswatch/flatly/_variables.scss#L106 (and all other themes) since this is a rails specific problem. However the "reimport" of bootswatch will break it again.
a better method is to add logic to the converter (https://github.com/maxim/bootswatch-rails/blob/master/converter) to delete this line from the variable files.
I'll see if I can make a pull request to this end later today.
from bootswatch-rails.
@ahmeij I'll remove that line from all themes and check with the > 3.2 rails versions. If you can add it to the converter and make that PR, it would be great!
Thank you.
from bootswatch-rails.
Agree with @ahmeij, maybe we should somehow make this document more prominent: https://github.com/maxim/bootswatch-rails/blob/master/CONTRIBUTING.md
from bootswatch-rails.
@maxim I have an update to the Readme ready, I'll make a pull request once #61 is merged (else I have to branch and rebase, too much effort for a readme ;-))
from bootswatch-rails.
I'll close this issue as @ahmeij already fix this with #61 PR. Thank you @ahmeij and @pablocrivella.
There is a new version of the gem which contains the fix (3.1.1.1).
from bootswatch-rails.
it works like a charm! thank's @esbanarango and @ahmeij 👏
from bootswatch-rails.
Related Issues (20)
- Remove http from @import statement when importing Google web fonts HOT 1
- @import's can't find bootswatch-rails's stuff HOT 6
- Update version at RubyGems HOT 3
- Less '&-' operator that SASS does not. HOT 2
- Bug on 'resolve_ampersand_dash' processor.
- Unable to make it work on rails 4.1.1 HOT 6
- Support bootstrap 3.2.0 HOT 2
- How do I import scss template files? HOT 4
- Precompilation issues HOT 11
- Sandstone HOT 3
- The theme Lumen doesn't match with that of the official site HOT 7
- How to change google font? HOT 1
- glyphicons-halflings not resolving HOT 7
- Readme: text-color instead of textColor
- Problem with javascript. HOT 4
- Undefined Mixin Bug HOT 3
- Incompatible units: 'rem' and 'px'. HOT 4
- Sass::SyntaxError: Undefined variable: "$navbar-default-bg".
- Update to the new, fresh, and exciting Bootswatch themes. Both Sketchy and Minty look pretty sweet. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootswatch-rails.