Coder Social home page Coder Social logo

Comments (11)

pcriv avatar pcriv commented on June 12, 2024

copying the fonts to app/assets/fonts seems to solve the issue... but... why? 😕 is the gem missing these fonts? sorry for my lack of understanding on how this works.

from bootswatch-rails.

esbanarango avatar esbanarango commented on June 12, 2024

@pablocrivella We don't provide those fonts. bootstrap-sass is the one that have them:
https://github.com/twbs/bootstrap-sass/blob/115fa1e5338489c312bb7131284d9badd4c18cec/lib/bootstrap-sass/engine.rb#L5

I'll investigate if the version you're using of bootstrap-sass (3.1.1) is having this issue.

from bootswatch-rails.

pcriv avatar pcriv commented on June 12, 2024

If it is of any help, i'm using Rails 4.1 and sass-rails 4.0.3.

from bootswatch-rails.

ahmeij avatar ahmeij commented on June 12, 2024

The variables.css.scss files of the swatches define:

$icon-font-path:          "../fonts/" !default;

comment that line out of the file and the problem is fixed

from bootswatch-rails.

pcriv avatar pcriv commented on June 12, 2024

@esbanarango so changing this line https://github.com/thomaspark/bootswatch/blob/gh-pages/flatly/variables.less#L75
(and for every other bootswatch theme) to use sass-rails font helpers could solve it.

from bootswatch-rails.

ahmeij avatar ahmeij commented on June 12, 2024

I would change it here: https://github.com/maxim/bootswatch-rails/blob/master/vendor/assets/stylesheets/bootswatch/flatly/_variables.scss#L106 (and all other themes) since this is a rails specific problem. However the "reimport" of bootswatch will break it again.

a better method is to add logic to the converter (https://github.com/maxim/bootswatch-rails/blob/master/converter) to delete this line from the variable files.

I'll see if I can make a pull request to this end later today.

from bootswatch-rails.

esbanarango avatar esbanarango commented on June 12, 2024

@ahmeij I'll remove that line from all themes and check with the > 3.2 rails versions. If you can add it to the converter and make that PR, it would be great!

Thank you.

from bootswatch-rails.

maxim avatar maxim commented on June 12, 2024

Agree with @ahmeij, maybe we should somehow make this document more prominent: https://github.com/maxim/bootswatch-rails/blob/master/CONTRIBUTING.md

from bootswatch-rails.

ahmeij avatar ahmeij commented on June 12, 2024

@maxim I have an update to the Readme ready, I'll make a pull request once #61 is merged (else I have to branch and rebase, too much effort for a readme ;-))

from bootswatch-rails.

esbanarango avatar esbanarango commented on June 12, 2024

I'll close this issue as @ahmeij already fix this with #61 PR. Thank you @ahmeij and @pablocrivella.
There is a new version of the gem which contains the fix (3.1.1.1).

from bootswatch-rails.

pcriv avatar pcriv commented on June 12, 2024

it works like a charm! thank's @esbanarango and @ahmeij 👏

from bootswatch-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.