Comments (3)
Hi, good proposals. Let me review your PR and think about it after some rest and I come back to you. Thanks!
from go-testdeep.
#150 just reviewed.
After some thought, I am not sure AlwaysParallel()
method is a good idea. I understand the concern, but won't this setting be unusual for the readers? As usually each subtest has to be explicitly set as parallelizable, it could be non-obvious to understand why a test runs in parallel while no Parallel() call is around.
from go-testdeep.
#150 just reviewed.
After some thought, I am not sure
AlwaysParallel()
method is a good idea. I understand the concern, but won't this setting be unusual for the readers? As usually each subtest has to be explicitly set as parallelizable, it could be non-obvious to understand why a test runs in parallel while no Parallel() call is around.
Reasonable. That was just something that could be possible once Parallel was supported but obviously an optional feature. If you feel that the confusion it would cause is more than its value, we can omit it.
from go-testdeep.
Related Issues (20)
- deepValueEqual infinite recursion with recursive map types HOT 3
- Recursive SubMap/SuperMap? HOT 4
- Comparison of reflect.Value types HOT 8
- Expose some internal types, so custom operators can be built HOT 1
- Add comparison to github.com/go-test/deep HOT 3
- Ignore unexported struct fields? HOT 13
- Add tdhttp.Path() function HOT 1
- Missing Test Name in error message When Using tdhttp.TestAPI inside a test of tdsuite HOT 1
- anchors not working with table driven tests / multiple t.Cmp calls HOT 2
- Add support for quotation marks in JSON operators HOT 3
- Replace bytes.Buffer by strings.Builder HOT 1
- Test failure: TestRun/Without_ptr:_only_non-ptr_methods HOT 4
- Allow to set default values in requests issued by a tdhttp.TestAPI HOT 1
- Add JSON operator HOT 1
- Add Catch operator HOT 1
- Allow to embed operators directly in go data structures HOT 2
- Add new operators SubJSONOf and SuperJSONOf HOT 1
- Rework tdJSON.String() method HOT 1
- remove Run method from TF interface HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-testdeep.