Comments (18)
I am sorry that I had made the changes to the admin UI that caused this confusion as well.
What can I do to help clear up the code for this?
I will go though the admin pages and work on addressing all the issues that are in violation.
from plex-movie-poster-display.
It okay, we live and learn.
I am not sure on the color scheme yet. I am open to suggestions.
Once the color scheme is decided work can begin on a new, built from scratch, bootstrap(?) frontend. It can keep all the same poster display features, however absolutely no PLEX scripts, CSS, HTML, etc. can be used.
This started as a side project and I am so surprised / happy that others are interest in using it... much less helping with development.
from plex-movie-poster-display.
When you say not PLEX scripts. What do you mean by that? Are we still able to keep using the API?
It feels like the violation is more on the cosmetic level.
I can help work on rewriting the admin interfaces since it was me who did most of the rewrite in the first place.
I had been working on moving all "Plex" related logic into its own library so this may be a good time to continue to move that logic around. None of that logic is Plex proprietary.
If we build it in such a way we should be able to "change" themes in and some needs change.
from plex-movie-poster-display.
Also what would you like to call the project?
Do we still want to call it Poster Display? What had you envisioned this to grow into?
I have been looking at this project as a digital kiosk, and could grow into something outside of Plex, but keep that as a base. Possibly even having it for other media applications or for even photos.
from plex-movie-poster-display.
As you think of what direction you would like to take the project. Give me through the weekend to work on a cleaner version of the settings pages.
I will work on stripping any Plex images and links.
Removing pointers to the CSS file. There looks like a bunch of CSS that we may not need. I have also identified a few areas that can be improved anyways.
I will have it in my forked branch and will tag this ticket when I do my commits. You are more then welcome to pull my branch and review the progress as I go so that we stay on the same page.
Once we stream lined the css files then it should be easier to apply your custom designed theme faster.
from plex-movie-poster-display.
Yes, as long as the projects stays within the term it can use the Plex API, webhooks, etc.
Still working on the color scheme / name options. Suggestions are always welcome.
I would like the project to be compatible other streaming platforms in the future (Example Jellyfin / Emby); as well as have the ability to display art and photos. Maybe a more modular design.
from plex-movie-poster-display.
Update
Still working on a layout, name, etc.
Layout
Looking at using the latest Bootstrap and Bootstrap Icons. Terms
Color Scheme
Still open to suggestions / ideas.
HEX Example Usage
#222831 Background
#393E46 Hover
#00ADB5 Button
#EEEEEE Text
from plex-movie-poster-display.
Ok, cool.
Did you want to keep a similar type of layout? as in the sections on the left side and the main in the right?
As long as we are not using any of the css, fonts and colors I think the flow should still be safe to use.
I have a bunch of ideas to optimize but without using alot of 3rd party resources.
from plex-movie-poster-display.
I am pretty close to having all the css cleaned up for the settings page.
Do you have a new font in mind?
I have been using your above colors but I have taken some liberties with them just for testing purposes.
I am hoping to have this cleared up by the end of the weekend. That should clear up most of the color/icon/style issues.
Let me know if you have any more info as to what you would like changed or see, or any directions you would like to take.
from plex-movie-poster-display.
I believe I now should be complete with the decoupling of the PLEX branding inside of the setting.
I have been trying to isolate what is "PLEX" and what is "Movie Poster Display". If you run my latest branch you will see that I am testing out any settings for a "PLEX" server into its own page. That way we could add different types of Media servers going forward.
from plex-movie-poster-display.
Thank you. I will check it out soon as I am back at home.
from plex-movie-poster-display.
Sure, no problem.
I will have a few more code drops in the next day or two for your consideration and hope to have a v2.10 PR with these changes within the next few days so we can get to an "Unblocked" state and then I can do some polish as I fix up more of the bugs that have been popping up and back to working on features.
from plex-movie-poster-display.
All Plex images are now removed.
PLEX CSS file still exists but will be removed in next commit.
To-Do:
New frontend with unique code and color scheme.
- Frontend has been refactored and 90% of the CSS has either been renamed & changed formatting, some of the "css classes" are stock classes so no copywrite infringement should be clamed. More refactoring can and will be done for simplification.
- Skeleton structure remains but changed as not specific to PLEX.
- Home icon has also been changed to a generic "home"
- Most colors have been set as per the above.
Audit all code to make sure there is no other trademark / copyright infringements.
- Frontend display no longer displays "Plex Movie Poster Display"; currently stripped down to "Movie Poster Display"
- Only reference that remains to PLEX is there is a "Plex Configuration Page", and this page is the only location that PLEX settings would be set. It also includes the PLEX copywrite footer.
Possible new name for project.
- Current placeholder name has been set to "Movie Poster Display"
Outstanding Items:
- Final "first pass" of CSS cleanup
- Review if Config.php values need to be modified and change from using "pmp" - Possible change for V3 as that would be more of a breaking change, the majority of the changes currently have been cosmetic to preserve backwards compatibility.
- Once name has been decided the "plexmovieposter" folder can be renamed and pointers adjusted
- A font for the Setting to be selected
- Proper complete documentation in the ChangeLog.
Notes:
- I have refrained from using 3rd party assets such as BootStrap as much as I can so that we contain more control and use stock functionality so we don't have to worry about any potential terms conflicts.
from plex-movie-poster-display.
Any more thoughts on font or colors?
I still have tweaks to make in the backend.
What other changes would you like to see?
from plex-movie-poster-display.
Sorry, I am still reviewing. Let me get back to you this week. Thank you for all the hard work.
-Matt
from plex-movie-poster-display.
No worries.
I have a few more changes coming in the next few days.
from plex-movie-poster-display.
Hey @MattsShack
Sorry I have been MIA for the past few weeks. I just started a new job and been spending all my time at that.
Have you had a chance to see what new changes you are looking for so we can look at closing this ticket?
I hope to jump back on the project in the next few weeks and hope to help clear up the backlog of issues that we have to a much smaller amount by the summer.
from plex-movie-poster-display.
@ZeroCoolGOS Welcome back. :)
Congratulations on the new job!
from plex-movie-poster-display.
Related Issues (20)
- Plex Configuration page enhancements
- Show/Hide Advanced Option
- Post Warning if Refresh is below 10 sec. HOT 2
- Config Documentation Update Sept. 2021
- TV Show Display Issues
- Test Suite and Framework
- Diagnostics Updates Sept/Oct 2021
- Assistance with SSL setup for use with HTTPS HOT 1
- Adjustments for Title Sizes
- When nothing is playing stays blank or still shows now playing
- Title logo in Now Showing
- Fonts Import Not Working with Bullseye Version HOT 1
- Poster Statistics incrementing, permanent blank screen regardless. HOT 48
- New Plex Media Server Update Broke PMPD3 HOT 2
- Enhancement: Settings page mobile friendly
- Update Website screenshots HOT 10
- Quick fix = Remove invalid footer under plex configuration page HOT 4
- Enhancement: Clear Cache for Fonts, Custom Images, Logs. Confirmation. HOT 1
- Register Movie Poster Display as Authorized Device
- BUG: SSL Connection not working as expected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plex-movie-poster-display.